Xinnony wrote:Hi everyone,
I want to explain what is going a little behind the scenes.
For several years I develop and fixes bugs in the FA Lobby.
Often people on FAF wonder of the new features I note and I publish.
Hey Xinnony,
This isn't behind the scenes. Anyone interested in what we're doing can do so
publicly on github and contribute themselves. I don't know what you mean by "Often people on FAF wonder of the new features I note and I publish." -- we've got public changelogs updated very frequently, these are replicated here on the forums as well.
Xinnony wrote:A new developer is arriving there shortly, and start editing, deleting and renaming all my scripts causing some problems.
Which made me a little furax because now I also do not recognize my own scripts.
I said that without me the Lobby would remain in this state : (without the 16 slots)
http://media.moddb.com/images/downloads ... enshot.PNG
FAF is truly open source now. This means that we need the code in a state that is as readable as possible, and technical improvements are welcomed as they improve the long-term maintainability of the project immensely, allowing people who haven't worked on it for years to jump in and contribute.
Xinnony wrote:I start the first state.
PNG conversion in the DDS Lobby and new fonts and colors.
Before IceDreamer or other pic its crisis, I said that I would attack anyone, I just said what bothers me, so no need to insult me again.
I find that the changes he has done makes ugly Lobby is my opinion, but I turn to the community as it is for them that we develop in this game, not for us personally.
I find that the quality is degraded, and new colors, fonts are not very pretty.
I haven't noticed the visual changes myself, and I don't believe these are an intended consequence of the work that has done, so this is a regression. We'll get this reported this on github so we can track it.
solarflare_nz wrote:I did notice that the lobby did not look quite as nice recently, but I don't mind since it's only for getting a game started and the functionality is the most important thing for me.
It is important to keep the code maintainable though, and if it's making it hard for you perhaps you need to alter the change/collaboration process? who is the "product owner" for the lobby?
These visual regressions aren't released yet -- they would've gone in with patch 3639 if we Xinnony hadn't reported them.
Xinnony wrote:Unfortunately not, he spends his time has brag of her graduate and delete what does not like or what he does not understand.
My script is destroyed day after day with more and more limited functions or remove, I shouted several recovery and am angered me, but every time I got spit on.
This is important: lobby.lua does not
belong to you, me or anyone (Maybe someone who bought GPG can claim it). I, and everyone else, very much apreciate your contributions but they are just that. Contributions to something we can all collaborate on and improve together.
This requires that no single person takes ownership of any parts of the code.
Xinnony wrote:This is Sheoo which approves new, and unfortunately it lets modifications that should not.
The changes you mention here were all discussed publicly on github, this is not a behind the scenes approval process. I did not approve visual changes and I assumed the previous look was preserved.
If this was mentioned in the discussions before merging, I would've waited until it had been resolved before merging.
Xinnony wrote:There are others damages ...
Eg, the "Map Background" option on the Lobby, the new developer, Sheoo and IceDreamer really wanted to remove, if Visionnik would not have expressed disagreement, he'd be available any more.
I guess you're talking about this public discussion?
https://github.com/FAForever/fa/issues/227.
I'll quote myself:
Sheeo wrote:If it's in use, then let's keep it though
Xinnony wrote:Just because they do not like her.
If I put a lot of options, it is to ensure that everyone can be customized according to their preference Lobby.
I do not think that has me personally, not like some ...
Thank Visionnik for avoiding that one delete options without reasons.
@Rogueleader89, The Source code is Open Source, but is Sheoo approving the changes.
Being merged with develop branch does not mean it's released or finally approved. We go through a review process before develop makes it to master (Which so far is always the latest available version) -- details of how this is done are still to be settled by the council. Perhaps this part of the process is where you want more openness?
