Kind of a glitch in Score.lua

[Koecher]

Hey ZePilot,

I've just randomly noticed that you used the same variable name twice in the same function for different things in the score.lua file, depending if its the normal FAF file oder score.lua used for GW.
Currently this isnt a problem (as ofc just one of both files is used), but depending on what else you're going to do with the GW files, it might become one I think.

In the normal FAF score.lua there is:

Code: Select all

      local playerName = line.name:GetText()
      local playerRating = sessionInfo.Options.Ratings[playerName]
      if (playerRating) then
         playerNameLine = playerName..' ['..math.floor(playerRating+0.5)..']'


while in the GW score.lua is:

Code: Select all

            local playerName = data.nickname
            local playerRank = sessionInfo.Options.Ranks[playerName]
            if (playerRank) then
                playerName = ranks[data.faction][playerRank+1] .. " " .. playerName
            end           


No idea if you've done this by accident or on purpose, just wanted to give a heads up on that.

[johnie102]

Isn't it that Rating refers to the trueskill rating (median - 3* deviation) while Rank refers to one of eight available ranks in GW?
That is at least what I can tell from the code you posted below.

[Ze_PilOt]

Exactly yes.

[Koecher]

Isn't it that Rating refers to the trueskill rating (median - 3* deviation) while Rank refers to one of eight available ranks in GW?

Thats not what I wanted to mention. Just wanne tell than in both "local playerName" is used, with the same variable name for different "jobs". So if the 2 different score files are merged some day for some reasons, it'll perhaps give a problem. Thats what I wanted do mention

[johnie102]

Isn't it that Rating refers to the trueskill rating (median - 3* deviation) while Rank refers to one of eight available ranks in GW?

Thats not what I wanted to mention. Just wanne tell than in both "local playerName" is used, with the same variable name for different "jobs". So if the 2 different score files are merged some day for some reasons, it'll perhaps give a problem. Thats what I wanted do mention

Ah yes. I see
It's still ok as far as I can see. In GW the rank of the person should be part of the full name, while the rating of a person definately isn't part of the name of the person and shouldn't be in the playername.