Need help making changes to the in game lobby

Post here if you want to help developing something for FAF.

Re: Need help making changes to the in game lobby

Postby speed2 » 20 May 2016, 05:09

*COUGH* 1366x768 *COUGH*
User avatar
speed2
Contributor
 
Posts: 3137
Joined: 05 Jan 2013, 15:11
Has liked: 614 times
Been liked: 1079 times
FAF User Name: speed2

Re: Need help making changes to the in game lobby

Postby CavemanHost » 20 May 2016, 11:24

IceDreamer wrote:There simply isn't enough space to do it, because we're limited by having to support a minimum 1280*1024 resolution or something dumb and old.

Yeah unfortunatly. :-(

I did some experiments yesterday. I think it is possible to decrease the size of the table of players just enough so make the map preview double its size.

If it is possible to have that label beside the commander symbol (with the functionality of the table of players), it should in theory be possible to get rid of the table of players. And that would free up a lot of screen space.

Drag and drop is not doable without getting the position of the mouse cursor, unfortunatly. But it should be possible to do something like this:
1 Click on not empty spot on the map preview
2 Store slot number
3 Click on another not empty spot on the map preview
4 Swap players
User avatar
CavemanHost
Avatar-of-War
 
Posts: 78
Joined: 27 Jan 2016, 14:26
Has liked: 53 times
Been liked: 15 times
FAF User Name: CavemanHost

Re: Need help making changes to the in game lobby

Postby Exotic_Retard » 20 May 2016, 11:28

i kinda really like the idea of drag and drop on the map directly.
i do suspect lots of potential issues but i hope this will come to something.

the size constraint certainly does make things interesting, but not impossible.
we can also look at the option of a "widescreen" setting so those with large screens can use more of them, or some kind of size adjustment.

some initial thoughts:
option to hide all the details from the map preview - so you can see the map without obstruction just like the large preview currently works.
the columns in the tables probably need to all stay, and they do take quite a bit of space. for small screens this is indeed an issue.

this has my support, good luck with it, if you need any sort of help or advice dont hesitate to ask.
User avatar
Exotic_Retard
Contributor
 
Posts: 1442
Joined: 21 Mar 2013, 22:51
Has liked: 550 times
Been liked: 615 times
FAF User Name: Exotic_Retard

Re: Need help making changes to the in game lobby

Postby CavemanHost » 20 May 2016, 14:32

I actually do need help with git. What is the work flow for submitting changes to faf? Do I use my own fork for that? Or do I work in a branch of the actual repository of FAF?
User avatar
CavemanHost
Avatar-of-War
 
Posts: 78
Joined: 27 Jan 2016, 14:26
Has liked: 53 times
Been liked: 15 times
FAF User Name: CavemanHost

Re: Need help making changes to the in game lobby

Postby CavemanHost » 20 May 2016, 15:46

Look at this magic. :D
Image
User avatar
CavemanHost
Avatar-of-War
 
Posts: 78
Joined: 27 Jan 2016, 14:26
Has liked: 53 times
Been liked: 15 times
FAF User Name: CavemanHost

Re: Need help making changes to the in game lobby

Postby keyser » 20 May 2016, 17:09

a rating of 3200 Oo
Zockyzock:
VoR is the clan of upcoming top players now
keyser
Councillor - Game
 
Posts: 1766
Joined: 17 May 2013, 14:27
Has liked: 413 times
Been liked: 500 times
FAF User Name: keyser

Re: Need help making changes to the in game lobby

Postby Exotic_Retard » 21 May 2016, 15:24

ok so the way things work is kinda like this:
im assuming you know how to use git in general. no need for super advanced stuff; really basic ui knowledge will do.

in faf we use a development model that looks something like this:
http://nvie.com/posts/a-successful-git-branching-model/

we have a develop branch and a master branch. when you want to add some feature or whatnot you can take a copy of that branch, put your changes in and then merge it with a pull request. a pull request is just like a merge except its tagged with a "check me please".

having just said that, in reality our fa branching is a total mess xD

just ask icedreamer on which branch to take and what to merge into. i suspect it will be release/3654 but no promises.


(personally i just give code to him in pastebin/make him do it for me/cry about sth and hope it gets fixed, but im not super much of a coder so theres that too xD)
User avatar
Exotic_Retard
Contributor
 
Posts: 1442
Joined: 21 Mar 2013, 22:51
Has liked: 550 times
Been liked: 615 times
FAF User Name: Exotic_Retard

Re: Need help making changes to the in game lobby

Postby IceDreamer » 23 May 2016, 01:39

Gimme that PR, and I will be very glad to merge it in for you :D

EDIT: Target develop branch please.
IceDreamer
Supreme Commander
 
Posts: 2600
Joined: 27 Dec 2011, 07:01
Has liked: 138 times
Been liked: 481 times

Re: Need help making changes to the in game lobby

Postby CavemanHost » 23 May 2016, 07:06

I got a unkown System message error on the Client side, after implementing the Player swap via click & click. Have to work out why that happens, but I can merge the Rating Label code. :-)
User avatar
CavemanHost
Avatar-of-War
 
Posts: 78
Joined: 27 Jan 2016, 14:26
Has liked: 53 times
Been liked: 15 times
FAF User Name: CavemanHost

Re: Need help making changes to the in game lobby

Postby CavemanHost » 23 May 2016, 10:37

Can't create pull requests. The git desktop app says I don't have permssions to do so.
User avatar
CavemanHost
Avatar-of-War
 
Posts: 78
Joined: 27 Jan 2016, 14:26
Has liked: 53 times
Been liked: 15 times
FAF User Name: CavemanHost

PreviousNext

Return to Contributors

Who is online

Users browsing this forum: No registered users and 1 guest