UEF rambo sACU are broken.

[BRNKoINSANITY]

If you use the preset UEF sACU you can't select all sACU and build as a group... They lay down one tick worth of building and then cancel themselves. I tried this with aeon and sera coms, and didn't have the problem. To get the all to build with each other you have to build with one and assist with the others.

[Tokyto]

This problem is with every faction SACUs, if u select 2+ SACUs and tell them to build something (without walking), they just dont do it

[IceDreamer]

So far I have been unable to fix this bug, I can't even work out why it's happening. Some people thought it was to do with multiple energy drains but it happens with default SCUs sometimes too, which is odd. For the time being to get around the problem, select the group, have them all assist one, then give that one the orders.

[pip]

This bug occurs for every engineer unit that has a separate energy drain from the energy drain when building. That's why sparkies got free radar jamming, so that they are not affected by this bug anymore. In case of SACU, the bug will occur when they have a shield, or a stealth / cloack upgrade or any other upgrade that drains energy.

[IceDreamer]

But why does it only happen when you have multiple selected? One at a time this never happens.

[BRNKoINSANITY]

That makes more sense..... I tried it with normal sACU and with a couple other presets and didn't have the problem so I assumed it was only UEF rambo, but any unit with power drain would make sense.

[IceDreamer]

Still doesn't explain why it only happens when multiple are selected.

[Crotalus]

Seems to have to do with rebuild fraction check.

For some reason fraction of a new structure isn't 0 when you're building with 2+ e-draining engineers.

A simple fix is to check if it's >0.01 instead of > 0 in lua/sim/Unit.lua, function CheckFractionComplete,

Code: Select all

CheckFractionComplete = function(self, unitBeingBuilt, threadCount)
        -- rebuild bonus check 1 [159]
        -- This code checks if the unit is allowed to be accelerate-built. If not the unit is destroyed (for lack
        -- of a SetFractionComplete() function). Added by brute51
        local fraction = unitBeingBuilt:GetFractionComplete()
        if fraction > (self.InitialFractionComplete or 0.01) then
            unitBeingBuilt:OnRebuildBonusIsIllegal()
        end
        self.InitialFractionComplete = nil
    end,


[IceDreamer]

Where is that located, and is it tested working?

[Crotalus]

Yeah, I've tested it and it's working as far as this bug at least. You have to update lua/sim/Unit.lua with the change above (0 -> 0.01)

Maybe there's a better solution with preventing fraction > 0 when multiple e-drawing engineers start a building something but haven't found where that would be handled.