(Anti)Nukes don't show adjaency bonus mid-construction

Moderator: keyser

(Anti)Nukes don't show adjaency bonus mid-construction

Postby errorblankfield » 04 Nov 2013, 03:26

Was messing around with building templates and I realized that if you add a mass fab or pgen to a anti or nuke while it's making a nuke, the consumption doesn't go down on the UI stats.

Not sure if it actually does use less mass/power after it's built but the UI doesn't reflect a change so I'm assuming it doesn't. Restarting it works. Didn't try pause/unpausing.

Might update later when I do that.
errorblankfield
Priest
 
Posts: 409
Joined: 15 Mar 2013, 16:21
Has liked: 7 times
Been liked: 11 times
FAF User Name: errorblankfield

Re: (Anti)Nukes don't show adjaency bonus mid-construction

Postby The Mak » 04 Nov 2013, 06:10

You mentioned you restart it, you hit stop and hit the auto build and it did not show a difference in resource consumption?

Typically the new resource consumption occurs on the next built item, at least, on factories anyway.
User avatar
The Mak
Contributor
 
Posts: 342
Joined: 03 Mar 2012, 21:09
Location: New York, NY, USA
Has liked: 5 times
Been liked: 39 times
FAF User Name: The_Mak

Re: (Anti)Nukes don't show adjaency bonus mid-construction

Postby Mycen » 04 Nov 2013, 17:57

The Mak wrote:You mentioned you restart it, you hit stop and hit the auto build and it did not show a difference in resource consumption?

Typically the new resource consumption occurs on the next built item, at least, on factories anyway.


Exactly. That's why restarting it works but pausing it does not. If one is critically concerned with getting the adjacency bonus for every missile, build the fabs/pgens first, then the silo. It's only really noticeable for missiles, because their build times are so long. For everything else it's not a big deal.
Mycen
Evaluator
 
Posts: 514
Joined: 12 Feb 2013, 03:20
Has liked: 12 times
Been liked: 40 times
FAF User Name: Mycen

Re: (Anti)Nukes don't show adjaency bonus mid-construction

Postby The Mak » 04 Nov 2013, 18:22

Just tested and it works as I stated above.

In the below image I have 3 anti-nukes queued up (from left to right):
- stand alone anti-nuke
- anti-nuke, T2 mass fab, and T2 power generator (in that order)
- T2 mass fab, T2 power generator, and anti-nuke (in that order)
antinuke01.png
Anti-nukes queued
antinuke01.png (1.54 MiB) Viewed 1710 times



At the point that all construction is complete you can see that the two left anti-nukes are consuming the same resources, while the one on the far right is consuming less due to adjacency.
antinuke02.png
Anti-nukes built
antinuke02.png (5.1 MiB) Viewed 1710 times



Now for the middle anti-nuke, I hit stop, then right click on auto build. You can now see that it is consuming less resources due to adjacency correctly.
antinuke03.png
Adjacency bonus corrected
antinuke03.png (4.63 MiB) Viewed 1710 times



So you can see that adjacency is working correctly but it is only calculated if the adjacent structures are there when a unit begins producing. This is true even for resource production structures and an adjacent structure just completes. This only occurs for one game tick (1/10th of a second) though because on the next game tick the resource structure produces its next unit of resource and the adjacent structure is there.


Now this is not directed entirely to you, but to all who post an issue they may have found. Test to make sure there is an actual problem. Do not go posting on the forum when you perceive there is a problem and you have not tested it. You are distributing incorrect information and worse of all you send an alarm up asking someone to spend time on a problem that does not exist. Do a test in sandbox first and have evidence as well as write clearly what you think the problem is and how you tested it. Basically, please do not pull alarms when no problem exists.
User avatar
The Mak
Contributor
 
Posts: 342
Joined: 03 Mar 2012, 21:09
Location: New York, NY, USA
Has liked: 5 times
Been liked: 39 times
FAF User Name: The_Mak

Re: (Anti)Nukes don't -have- adjaency bonus mid-construction

Postby errorblankfield » 06 Nov 2013, 12:00

Didn't mean to 'raise an alarm' it was more of an FYI.
Since the bloody things take a year to make, I thought it was worth noting this behavior on missiles.

While I think that the bonus should apply immediately (within a few ticks or so), I didn't mean to suggest they aren't working at all. Merely, they work, but only on fresh missiles.

If you read the post, I literally stated that the UI doesn't change and offered two explanations. Either it UI is wrong or the consumption isn't changing until a new event starts (new missile).

I wasn't really in position to test the consumption rate so I just posted my findings thus far in hopes to spread the word and/or have someone else figure out what is going on -which I think you kindly for doing.
I wasn't trying to say it's wrong, just show what's going on for something that might not be intuitive to all.

It's likely my fault for wording things too literally. When I said it's not showing an adjacency bonus, the reason that their isn't one yet is valid. I'm not saying it should be showing one, just that it's not currently showing one.

Now that that's been explained, I do have a formal suggestion...

Have the bonuses applied immediately -even if only in the case for missiles. The game does this for mexes and pgens already so it shouldn't be impossible from that standpoint.

I'd love to tinker in the code to implement this suggestion but I'm not even remotely close to understanding the code in this game yet enough to do it.
I know unit spawning is a bit wonky so it might not be possible to change the consumption rate mid-construction. However, perhaps a workaround where the adjacent buildings produce (even if off) the difference until the next event occurs would work.

Perhaps on the day I figure out how to make the recharge bar on arties start filled when you have adjacency bonus (instead of just no having to fill all the way), we could draft a more direct solution where the build order is canceled and restarted with the current progress saved as it adjusts consumption.

Or the code might not suck completely* and it's a simple copy/paste to check nearby when something is built and accordingly. (Just a thought.)

Again, sorry for any misunderstanding.

-Cheers
#Posting at 5 in the morning

*Not forged code, the game code!
errorblankfield
Priest
 
Posts: 409
Joined: 15 Mar 2013, 16:21
Has liked: 7 times
Been liked: 11 times
FAF User Name: errorblankfield


Return to FAF Suggestions

Who is online

Users browsing this forum: No registered users and 1 guest