Lag-out window covers exit game option

[Spy_Emanciator]

Hello,

Common frustration, 1 player lags out early and the game has to be RE'ed. Except that Lagout window is positioned so it covers the bottom half of the options menu meaning you have to tab out and manually close the program.

Please put the options window above the lag window so people can easily close after failure.

[Little Miss Murder]

Alt-f4

[ZLO_RD]

i play borderless windowed. Just pressing alt+F4 does not work. If i mash alt+F4 many times it brings up dialog for closing the game, but game does not close. I still have to kill it with taksmanager.

[Uveso]

Switch option "Quick Exit" to on, and the game will exit on [ALt]+[F4] without any confirmation dialog

[Spy_Emanciator]

I realize there are work arounds. its an insult to injury issue. Logouts are bad enough without having to fight your own cpu to exit. fix window priority. Its copy pasta code position change.

[Uveso]

@Spy_Emanciator:

here is the corresponding code for the exit handling:
https://github.com/FAForever/fa/blob/develop/lua/ui/dialogs/eschandler.lua#L61

Feel free to do your copy & paste changes.

[Spy_Emanciator]

@uveso, thanks for this insight. unfortunately that is 1 layer too deep. What i'm talking about is the ongoing call of various windows in the program. The series in which they are listed determine what will show up on top of what (e.g. minimal showing on top of actual game terrain render). So what needs to be done is figure out in what manner the order of windows is being called, and reverse the placement of the options menu and the layout player list.

[Little Miss Murder]

I dont understand why it's such a hardship to enable quick exit and use alt-f4. What am I missing? Most people have quick exit enabled anyway regardless of any conn window.

[Uveso]

@uveso, thanks for this insight. unfortunately that is 1 layer too deep. What i'm talking about is the ongoing call of various windows in the program. The series in which they are listed determine what will show up on top of what (e.g. minimal showing on top of actual game terrain render). So what needs to be done is figure out in what manner the order of windows is being called, and reverse the placement of the options menu and the layout player list.

if you follow the function then it will lead to the line where the window is created:

Code: Select all

        quickDialog = UIUtil.QuickDialog(GetFrame(0), "<LOC EXITDLG_0000>Are you sure you'd like to quit?",

This leads us to the file /lua/ui/uiutil.lua line 824:
https://github.com/FAForever/fa/blob/develop/lua/ui/uiutil.lua#L824

You could maybe add someting like this to change the depth of the windows at line 831:

Code: Select all

dialog.Depth:Set(GetFrame(0):GetTopmostDepth() + 20)


I dont understand why it's such a hardship to enable quick exit and use alt-f4. What am I missing? Most people have quick exit enabled anyway regardless of any conn window.

And i don't understand how your comment can help us to fix the window position problem.

[Little Miss Murder]

I'm so tired of the fucking toxicity in this community. Can you parse that?