Lag-out window covers exit game option

Moderator: keyser

Lag-out window covers exit game option

Postby Spy_Emanciator » 10 Feb 2020, 22:54

Hello,

Common frustration, 1 player lags out early and the game has to be RE'ed. Except that Lagout window is positioned so it covers the bottom half of the options menu meaning you have to tab out and manually close the program.

Please put the options window above the lag window so people can easily close after failure.
Spy_Emanciator
Avatar-of-War
 
Posts: 62
Joined: 22 Jul 2018, 09:55
Has liked: 1 time
Been liked: 16 times
FAF User Name: Spy_Emanciator

Re: Lag-out window covers exit game option

Postby Little Miss Murder » 11 Feb 2020, 06:44

Alt-f4
Little Miss Murder
Avatar-of-War
 
Posts: 229
Joined: 30 Mar 2019, 12:20
Has liked: 132 times
Been liked: 29 times
FAF User Name: Little Miss Murder

Re: Lag-out window covers exit game option

Postby ZLO_RD » 11 Feb 2020, 09:57

i play borderless windowed. Just pressing alt+F4 does not work. If i mash alt+F4 many times it brings up dialog for closing the game, but game does not close. I still have to kill it with taksmanager.
http://www.youtube.com/user/dimatularus
http://www.twitch.tv/zlo_rd
TA4Life: "At the very least we are not slaves to the UI"
User avatar
ZLO_RD
Supreme Commander
 
Posts: 2257
Joined: 27 Oct 2011, 13:57
Location: Russia, Tula
Has liked: 303 times
Been liked: 397 times
FAF User Name: ZLO

Re: Lag-out window covers exit game option

Postby Uveso » 11 Feb 2020, 19:37

Switch option "Quick Exit" to on, and the game will exit on [ALt]+[F4] without any confirmation dialog
User avatar
Uveso
Supreme Commander
 
Posts: 1768
Joined: 11 Dec 2015, 20:56
Location: Germany
Has liked: 69 times
Been liked: 286 times
FAF User Name: Uveso

Re: Lag-out window covers exit game option

Postby Spy_Emanciator » 13 Feb 2020, 08:23

I realize there are work arounds. its an insult to injury issue. Logouts are bad enough without having to fight your own cpu to exit. fix window priority. Its copy pasta code position change.
Spy_Emanciator
Avatar-of-War
 
Posts: 62
Joined: 22 Jul 2018, 09:55
Has liked: 1 time
Been liked: 16 times
FAF User Name: Spy_Emanciator

Re: Lag-out window covers exit game option

Postby Uveso » 13 Feb 2020, 22:36

@Spy_Emanciator:

here is the corresponding code for the exit handling:
https://github.com/FAForever/fa/blob/develop/lua/ui/dialogs/eschandler.lua#L61

Feel free to do your copy & paste changes.
User avatar
Uveso
Supreme Commander
 
Posts: 1768
Joined: 11 Dec 2015, 20:56
Location: Germany
Has liked: 69 times
Been liked: 286 times
FAF User Name: Uveso

Re: Lag-out window covers exit game option

Postby Spy_Emanciator » 14 Feb 2020, 08:57

@uveso, thanks for this insight. unfortunately that is 1 layer too deep. What i'm talking about is the ongoing call of various windows in the program. The series in which they are listed determine what will show up on top of what (e.g. minimal showing on top of actual game terrain render). So what needs to be done is figure out in what manner the order of windows is being called, and reverse the placement of the options menu and the layout player list.
Spy_Emanciator
Avatar-of-War
 
Posts: 62
Joined: 22 Jul 2018, 09:55
Has liked: 1 time
Been liked: 16 times
FAF User Name: Spy_Emanciator

Re: Lag-out window covers exit game option

Postby Little Miss Murder » 14 Feb 2020, 09:12

I dont understand why it's such a hardship to enable quick exit and use alt-f4. What am I missing? Most people have quick exit enabled anyway regardless of any conn window.
Little Miss Murder
Avatar-of-War
 
Posts: 229
Joined: 30 Mar 2019, 12:20
Has liked: 132 times
Been liked: 29 times
FAF User Name: Little Miss Murder

Re: Lag-out window covers exit game option

Postby Uveso » 14 Feb 2020, 11:22

Spy_Emanciator wrote:@uveso, thanks for this insight. unfortunately that is 1 layer too deep. What i'm talking about is the ongoing call of various windows in the program. The series in which they are listed determine what will show up on top of what (e.g. minimal showing on top of actual game terrain render). So what needs to be done is figure out in what manner the order of windows is being called, and reverse the placement of the options menu and the layout player list.

if you follow the function then it will lead to the line where the window is created:
Code: Select all
        quickDialog = UIUtil.QuickDialog(GetFrame(0), "<LOC EXITDLG_0000>Are you sure you'd like to quit?",

This leads us to the file /lua/ui/uiutil.lua line 824:
https://github.com/FAForever/fa/blob/develop/lua/ui/uiutil.lua#L824

You could maybe add someting like this to change the depth of the windows at line 831:
Code: Select all
dialog.Depth:Set(GetFrame(0):GetTopmostDepth() + 20)


Little Miss Murder wrote:I dont understand why it's such a hardship to enable quick exit and use alt-f4. What am I missing? Most people have quick exit enabled anyway regardless of any conn window.

And i don't understand how your comment can help us to fix the window position problem.
User avatar
Uveso
Supreme Commander
 
Posts: 1768
Joined: 11 Dec 2015, 20:56
Location: Germany
Has liked: 69 times
Been liked: 286 times
FAF User Name: Uveso

Re: Lag-out window covers exit game option

Postby Little Miss Murder » 14 Feb 2020, 16:57

I'm so tired of the fucking toxicity in this community. Can you parse that?
Little Miss Murder
Avatar-of-War
 
Posts: 229
Joined: 30 Mar 2019, 12:20
Has liked: 132 times
Been liked: 29 times
FAF User Name: Little Miss Murder

Next

Return to FAF Suggestions

Who is online

Users browsing this forum: No registered users and 1 guest