Blackops ACUs overcharge bug(?)

[Wywern291]

So, I have noticed for a while that the Blackops ACUs mod makes the ACU overcharge deal 0 damage to all targets. This is pretty annoying for a mod which is supposed to make the ACUs more powerful in the lategame, since a lot of their base power comes from the overcharge. There is also an upgrade line for the seraphim ACU which increases overcharge damage... To zero. Now, I don't know if it's only me, since I haven't seen any discussion on this, but I reinstalled the mod and the problem persists. I don't recall this being a problem some time back, is there any way to fix this without messing around with code? Also does anyone know if the mod is being updated anymore? It is in the mod vault and a part of the fairly popular blackops package, so I'd assume this would have been noticed by someone.

Sorry this is a bit messy, I'm tired.

[Uveso]

Hello Wywern291,

welcome to FAForever

Thank's for reporting the overcharge bug, we will take a look at it.
I guess there will be no way to fix this without changing the code.

The mod is up to date and will get updates/patches if needed.

This is our Git-Hub page:
(where the sourcecode is, and where we are working on the mod)
https://github.com/aeoncleanse/Mods

If you want to make a bug report open a new "issue" here:
https://github.com/aeoncleanse/Mods/issues

And here you can see already written patches/updates that are waiting for a merge into the main code:
(Upcoming patches / fixes)
https://github.com/aeoncleanse/Mods/pulls

There you can see, the last patch was written 28 days ago.

You can also write everything here into the forum, i check both places at least every week.

Greetings, uveso.

PS: I opened a new issue on Git-Hub for the overcharge problem, so no need for you to do something
https://github.com/aeoncleanse/Mods/issues/259

[Wywern291]

Yes, this is my first time using these forums, and thank you very much for the quick response and making the bug report. The one thing more I would like to ask of anyone reading this is that they test if they can recreate the bug. On my client the bug appeared on every map I tried, and with multiple mod compositions. I tried the mod with multiple combinations of blackops unleashed, blackops experimentals, total mayhem and misc. mods like ninja reclaim drones, antinuke price etc. I also tried the ACU mod by itself, and even tried reinstalling it, and the bug appeared every time. All of the tests were conducted on the latest version of the FAF "mod" on the FAF client. Since the problem seems to be fairly recent, I would assume a FAF update that made changes to the overcharge damage type caused it. I will test this with the other base "mods" on the FAF client and edit this post accordingly once I have.

Would be nice to know that it isn't just something on my end messing up before someone goes through actual effort to try to fix the bug.

EDIT: Well I found another bug while looking at the other mods. The Nomads ACU doesn't deal any damage to ACUs or building with the overcharge, but does to units. Where should I report this?
EDIT: Using the Equilibrium mod, that also modifies overcharge, while uding the blackops ACUs mod the overcharge deals damage to units and structures, but none to ACUs. Without the blackops ACUs mod, overcharge deals damage correctly to all unit types.
EDIT: While using the LABwars mod, the ACUs again deal 0 damage to all targets with overcharge while using the blacops ACUs mod. Without the blackops ACUs mod overcharge damage is dealt correctly.
Since there are cases of the overcharge dealing no damage and also dealing damage to certain unit types, I would assume the issue is caused by the overcharge damage-type and how it applies to the different unit types.

[DDDX]

I received this from Uveso, when asking him why overcharge was not working on my custom unit:

Overcharge damage was changed in FAF.
I patched the overcharge on Black Ops ACU's by simply adding an extra array for the damage to the weaponblueprint.
So you need to do the same for your unit:

https://github.com/aeoncleanse/Mods/pull/260/files
The values with "-- for old game version" are for the actual game version
(i wrote this because i run only the development version of the game)

And the lower 5 values are for the next overcharge patch (already merged to the development game version):
https://github.com/FAForever/fa/commit/ ... 631e23b1a4

If you just use all 10 values (copy the whole overcharge array) then you are good to go for all game versions.