[bug] Phantom X - phantom is revealed

[Frozen_byte]

Even if all settings are set to "never" the Phantom will be revealed.
Tested twice.

[Duck_42]

Frozen_Byte,

I noticed the same thing while playing a phantom game. I tested the mod with AIs, and had the same problem. I checked the LUA code for the mod, and that's not the only bug in the mod. The way it's coded causes the problem you mentioned and also makes the reveal times cumulative.

For the following scenario:
Phantom 1 Reveal Time: 5 minutes
Phantom 2 Reveal Time: 5 minutes
Phantom 3 Reveal Time: 5 minutes

You'd expect the mod to have revealed all phantoms by 8 + 5 + 5 + 5 = 23 minutes. Instead, it ends up being 62 minutes
(8 assignment + (8 + 5 phantom 1) + (8+5+5 phantom 2) + (8 + 5 + 5 + 5 phantom 3).

I'm going to try to put together a fixed version of the code in the next few days and post it here. That being said, I don't have anything to do with FA Forever development, so I can't actually apply the fix.

[Duck_42]

Ok, here's the fix. Now we just need someone to patch FAF with it.

DISCLAIMER
This is the first LUA code I've actually written , so it's possible I could have goofed something up. I did run it through a quick test, and it appears to work right...

In PhantomSim.lua...

replace beginning of PhantomMainThread function with this...

Code: Select all

function PhantomMainThread()
#   cur.config.declare = ScenarioInfo.Options.PhantomDeclareTime
#   cur.config.vote = cur.config.declare - (1 * 60)
   
   #Bugfix #1: Removed cummulative addition of reveal times
   cur.config.reveal1 = (tonumber(ScenarioInfo.Options.PhantomRevealTime1) * 60)
   cur.config.reveal2 = (tonumber(ScenarioInfo.Options.PhantomRevealTime2) * 60)
   cur.config.reveal3 = (tonumber(ScenarioInfo.Options.PhantomRevealTime3) * 60)
   
   #Old Code
   #cur.config.reveal1 = cur.config.declare + (tonumber(ScenarioInfo.Options.PhantomRevealTime1) * 60)
   #cur.config.reveal2 = cur.config.reveal1 + (tonumber(ScenarioInfo.Options.PhantomRevealTime2) * 60)
   #cur.config.reveal3 = cur.config.reveal2 + (tonumber(ScenarioInfo.Options.PhantomRevealTime3) * 60)

   ...original function continues...


The DoneShowingPhantoms function doesn't really have to be changed, I just tweaked the wording a little...

Code: Select all

function DoneShowingPhantoms(cnt)
   if(cnt == 0) then
      Sync.pAlert("All Phantoms have been revealed.")
   end
   if(cnt == 1) then
      Sync.pAlert("Revealable Phantoms are now known.  One more remains hidden.")
   else
      Sync.pAlert("Revealable Phantoms are now known.  "..cnt.." more remain hidden.")
   end
end


Finally, replace the PhantomRevealThread function with this code...

Code: Select all

function PhantomRevealThread()
   LOG('starting phantom reveal thread')
#   WaitSeconds(cur.config.reveal1)

   pRevealed = {
      phant1 = nil,
      phant2 = nil,
      phant3 = nil
   }
   
   local maxPhants = table.getn(cur.phantoms)

   #BugFix 2:      Rearranged reveal logic to correctly handle all scenarios
   #Assumptions:   Once we encounter a reveal time of zero, it is assumed that all revelations are done. 
   #      i.e. If phantom 1's reveal time is Never, then phantoms 2 and 3 will not be revealed either.
   
   #Build a table to use in our loop
   local revealtimes = {}
   revealtimes[1] = cur.config.reveal1
   revealtimes[2] = cur.config.reveal2
   revealtimes[3] = cur.config.reveal3
   
   for index, p in cur.phantoms do
      #If reveal time is "never", break from this thread...
      if(revealtimes[index] == 0) then
         DoneShowingPhantoms(maxPhants - index + 1)
         do return end
      else
         WaitSeconds(revealtimes[index])
         Sync.pAlert = { ArmyBrains[p].Nickname.." is a phantom!", "KILL HIM." }
         LOG('revealed phantom: ', ArmyBrains[p].Nickname)
      end
      
      if(index == 1) then
         pRevealed.phant1 = ArmyBrains[p].Nickname
      end
      if(index == 2) then
         pRevealed.phant2 = ArmyBrains[p].Nickname
      end
      if(index == 3) then
         pRevealed.phant3 = ArmyBrains[p].Nickname
      end
      
      Sync.pRevealed = pRevealed
      LOG('syncing from sim')
   end
   
   WaitSeconds(10)
   Sync.pAlert("All Phantoms have been revealed.")
end


Here's the fixed LUA file in its entirety

PhantomSim.zip

Fixed PhantomSim.lua file for Phantom-X

(4.07 KiB) Downloaded 196 times

ok... bedtime.

[noobymcnoobcake]

Yes i noticed this too. Now if only we can get them to put that in update.

Does only the host need this fix? Or everyone in the game?

[Plasma_Wolf]

Doesn't really matter I think, we only have to let this be applied in a central FAF update and all accounts will follow as soon as they log in.

[Ze_PilOt]

That's the spirit, if you want something done, do it !

Thank you, I'm updating the online version.

[noobymcnoobcake]

Thanks Zep ^^

[uberge3k]

Thank you very much Duck_42, really appreciate the initiative.

[noobymcnoobcake]

Another issue - Storages have 3599 values. E storage only holds 2k. I believe they were changed so they dont go up and down. This is because you could tell who the phantoms were by watching then as phantoms get resource bonuses.

[Duck_42]

Changing the storage should just be a matter of adjusting the blueprint files. I'll see about fixing that.

I also misunderstood the Sync.pAlert syntax when I was fixing the LUA code, so I broke part of the announcements in my fix.

So, for the next fix, I've got:
-Fix announcement bug
-Correct energy and mass storage values
-Add phantom numbering to assignment display (so if you're phantom, you'll know where you are in the reveal order).
-Fix reveal countdown timer so that it doesn't keep counting down after all revealable phantoms have been shown.
(this only happens if Phantom 1 or 2 are set to never and phantom 2 or 3 are set to some number)