Shield effects missing - shield.lua

[bamboofats]

I noticed missing shield effects in my installation of FAF 3640, as compared to the original FA or vanilla SUPCOM.
The shield emitting particle effects and shield structure rotations were missing. (tested with 3 different computers)
This affects all shield generators and mobile shield units as well.

Refer to the attached pictures!

I traced this to 2 lines of code inside the shield.lua file.
The original unmodded supcom had these entries

-- INSIDE OnState = State {
self.Owner:OnShieldEnabled()

-- INSIDE OffState = State {
self.Owner:OnShieldDisabled()


While the FAF shield.lua had the self.Owner:OnShieldEnabled() lines removed.
I tried adding those 2 lines back and the effects were restored.

Is there a particular reason these were removed? I believe it was somewhere around FAF3636

Current effects using FAF latest version

Current effects using FAF latest version

FAF 3640.jpg (566.78 KiB) Viewed 1080 times

Original effects

Original effects

Vanilla FA.jpg (597.93 KiB) Viewed 1080 times

[Sheeo]

This is a regression. Good spot! Github issue created here. Expecting us to get this into 3641, which is scheduled to be released soon.

[IceDreamer]

Also, eternal thanks for such a brilliant bug report! This is how it should be done

Come help us all out with the code any time

[bamboofats]

Not a problem!

Just to clarify what i meant about the shield rotations that I noticed (aside from the particle effects).

*Original effects*
Shield toggled on:
Static Cybran/Aeon/UEF (T2/T3 etc) - shield structure rotates
Static Seraphim T2 T3 - spiky blob hovers
Aeon/UEF mobile shields - opens up it's shield device or whatever it is

Shield toggled off:
All static shields become stationary
Aeon/UEF mobile shields - stores the shield device

Toggling between on and off makes the structure accelerate to rotation speed or slow to a stop.
seraphim mobile shield and UEF shield boat dont seem to have any special animations to begin with, but they have the particle effects which are also missing in 3640

*FAF3640 effects*
Regardless of whether the user has toggled shields on or off
cybran/UEF - continues rotation
Aeon/Seraphim - does not rotate/blob lies on the floor
Mobile shields - stuck in the closed state


I didnt notice anything wrong with personal shield units though.