Replay vault Not working on Java Client

[Rowey]

When i try to search for a spesific player to watch a replay in the java clent is get an error everytime. not sure if thiis error is know but ill post my Error Details here https://pastebin.com/RqGj5jem

[Brutus5000]

Please tick the box "Display search query" and copy the content of the query here.

[Rowey]

in the new box that show up when ticking the box this ios waht it shows

id=="Yewor"

[Rowey]

or do u want the error wehn it happends ?

[Geosearchef]

Your request is indeed "bad" as the API replies. The id is the id of the replay (this shouldn't be a string/name). What did you enter as a search? Is the first field set to id? Try setting that to something like player and the comparison operator to like/contains.

[Rowey]

ahh ok that seems ot work now with it beeing set to "player name" "is" "Yewor". i think this need to be chanegd to defualt as is most like what peopel ill be doing and if they are jsut going to get the erro all the time they wont know what to do.

[Cuddles]

I'm getting the same problem

[Geosearchef]

You get the same answer . Please provide the search query.

[Chubbly]

I'm getting the same issue, I tested it on the most basic query: grab the ID of the game in the top of the Online Replays list and search.

Search query: id=="9351058"
Same issue if I use contains: id=="*9351058*"

Stack trace below.

Code: Select all

java.util.concurrent.CompletionException: org.springframework.web.client.HttpClientErrorException$BadRequest: 400 Bad Request
   at org.springframework.aop.interceptor.AsyncExecutionAspectSupport.lambda$doSubmit$3(AsyncExecutionAspectSupport.java:279)
   at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(Unknown Source)
   at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
   at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
   at java.base/java.lang.Thread.run(Unknown Source)
Caused by: org.springframework.web.client.HttpClientErrorException$BadRequest: 400 Bad Request
   at org.springframework.web.client.HttpClientErrorException.create(HttpClientErrorException.java:79)
   at org.springframework.web.client.DefaultResponseErrorHandler.handleError(DefaultResponseErrorHandler.java:97)
   at org.springframework.web.client.DefaultResponseErrorHandler.handleError(DefaultResponseErrorHandler.java:79)
   at com.faforever.client.api.JsonApiErrorHandler.handleError(JsonApiErrorHandler.java:31)
   at org.springframework.security.oauth2.client.http.OAuth2ErrorHandler.handleError(OAuth2ErrorHandler.java:172)
   at org.springframework.web.client.ResponseErrorHandler.handleError(ResponseErrorHandler.java:63)
   at org.springframework.web.client.RestTemplate.handleResponse(RestTemplate.java:777)
   at org.springframework.web.client.RestTemplate.doExecute(RestTemplate.java:735)
   at org.springframework.security.oauth2.client.OAuth2RestTemplate.doExecute(OAuth2RestTemplate.java:128)
   at org.springframework.web.client.RestTemplate.execute(RestTemplate.java:669)
   at org.springframework.web.client.RestTemplate.getForObject(RestTemplate.java:310)
   at com.faforever.client.api.FafApiAccessorImpl.getPage(FafApiAccessorImpl.java:587)
   at com.faforever.client.api.FafApiAccessorImpl.getPage(FafApiAccessorImpl.java:574)
   at com.faforever.client.api.FafApiAccessorImpl.findReplaysByQuery(FafApiAccessorImpl.java:322)
   at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
   at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
   at java.base/java.lang.reflect.Method.invoke(Unknown Source)
   at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:343)
   at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:206)
   at com.sun.proxy.$Proxy61.findReplaysByQuery(Unknown Source)
   at com.faforever.client.remote.FafService.findReplaysByQuery(FafService.java:299)
   at com.faforever.client.remote.FafService$$FastClassBySpringCGLIB$$6c91c77e.invoke(<generated>)
   at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
   at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:746)
   at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
   at org.springframework.aop.interceptor.AsyncExecutionInterceptor.lambda$invoke$0(AsyncExecutionInterceptor.java:115)
   at org.springframework.aop.interceptor.AsyncExecutionAspectSupport.lambda$doSubmit$3(AsyncExecutionAspectSupport.java:276)
   ... 4 more


[Geosearchef]

Equality works for me.
Seems like contains doesn't work, probably due to ID being an integer and

Code: Select all

https://api.faforever.com/data/game?filter=id==%22*9351058*%22

containing those stars.

Issue created: https://github.com/FAForever/downlords- ... ssues/1097