bug allows guaranteed win once enemy commander under 2.5k

[noobymcnoobcake]

Playing a 1v1 on open waters. both commanders were on midle island with some arty and we both got down to under 2.5k HP. he had far higher score than me and control of side islands. His commander was running into the water so my chance of getting a draw was now or never. I cntrk-K my commander as he stopped shooting because the other was in the water. However he was still in nuke range and we both died.

However here is the bug. He did not kill my commander. I killed it myself. So he dont get +1 for that. However I killed his commander. I get a +1. But I also lost my commander so I get -1. Result is XBX-DilliDalli -1and noobymcnoobcake 0. I won.

He understood i did not know about this bug and just wanted draw as it was clear it was gonna be draw or loss and anyone in my situation would have gone for draw. But this bug needs to be fixed. As soon as your opponent is under 2.5K hp then just kill your own commander and its guaranteed win.

[Fok]

Cheater ! we should reset your rating !!

joking

------> [x]

[Koecher]

Was it counted as a win for you (Ladder Points)?
Maybe its just displayed in a confusing way?

Following THIS the result "makes sense" even if it doesn't following what actually happened.

[noobymcnoobcake]

Was it counted as a win for you (Ladder Points)?
Maybe its just displayed in a confusing way?

Following THIS the result "makes sense" even if it doesn't following what actually happened.

I gained 13 ladder points and it did say I won

[Ze_PilOt]

In the replay, you said "Bet you I got a win". But you were still into the game, so I guess you are saying that because of the victory screen in FA. But it was always like that since supcom was released. Nothing new here.

In the log :

player 1 : info: GAMERESULT : \000defeat 0
player 2 : info: GAMERESULT : \000defeat -1

While in custom it's indeed resulting in one of the player winning, in ladder, the counting of points is slightly different, and should result in a draw.

Here is the code in the server :

Code: Select all

def addResultPlayer( player, faresult, score):
   
    if player in self.gameFaResult :
        if  gameFaResult[player] == "score" :
            # the play got not decicive result yet, so we can apply it.
            gameFaResult[player] = faresult
            #self.gameResult[player] = score
        else :
            if faresult == "defeat" and gameFaResult[player] == "victory" :
                if not player in self.invalidPlayers :
                    invalidPlayers.append(player)
                #if we try to set a defeat, but the player was victory.. We've got a disparity problem !
                #
            else :
                if faresult != "score" :
                    self.gameFaResult[player] = faresult
                    if faresult == "defeat" :
                        gameResult[player] = -1
                    if faresult == "victory" :
                        gameResult[player] = 1
                    if faresult == "draw" :       
                        gameResult[player] = -1                 
    else :
        gameFaResult[player] = faresult
        gameResult[player] = score   

You can check it with python :

addResultPlayer( player1, defeat, 0)
will result in "-1" for player1 :

Code: Select all

                    if faresult == "defeat" :
                        gameResult[player] = -1

for player two :
addResultPlayer( player1, defeat, -1)
Same.

So this replicate nothing, and according to the logs, the ladder is fine.