Default values of mod settings not respected

[EntropyWins]

Final Rush Pro4 4v4 has this setting definition:

Code: Select all

   {
      default = 0,
      label = "Auto Reclaim",
      help = "AutoReclaim.",
      key = 'opt_AutoReclaim',
      pref = 'opt_AutoReclaim',
      values = {
         {text = "Disabled (Wreckages On)", help = "Off", key = 0, },
         {text = "Auto Reclaim 10 percent", help = "10 percent", key = 1, },
         {text = "Auto Reclaim 15 percent", help = "15 percent", key = 2, },
         {text = "Auto Reclaim 20 percent", help = "20 percent", key = 3, },
         {text = "Auto Reclaim 30 percent", help = "30 percent", key = 4, },
         {text = "Auto Reclaim 40 percent", help = "40 percent", key = 5, },
         {text = "Auto Reclaim 50 percent", help = "50 percent", key = 6, },
      },
   },

When I change

Code: Select all

default = 7,

(the index for 50 percent), the lobby shows the 50 percent in the options menu as expected. However, when the game is started, it is not getting key=6. It does when in the option menu I open the dropdown and select (the already selected) default value. That step defeats the purpose of having the default option of course.

Lobby version 3659, no idea how long this has been broken

[Uveso]

Default is the key value.
You don't have a "key = 7"

Your option number seven has the key 6.

So if you want the option "{text = "Auto Reclaim 50 percent", help = "50 percent", key = 6, }," because of key = 6, you must write:

default = 6,

[EntropyWins]

Hey Uveso, that's what I assumed when I first looked at this as well. However that is not how it appears to work. If I put the default to 6, I the lobby will show the 40% option. In neither case does the game actually pick up the intended value.

I just verified this again.

[Uveso]

Well, i tryed to debug the map, but it has to many errors for a short view. (tryed version 0007)

But now i know, the option array is merged into the normal option array, and the default value is the index of the value array.

So default = 7, is indeed for the last (50%) option line.

This need further investigation.
Can you please post a issue report on Github ?

Name it like "Default game options from Maps are not used ingame"
Write some lines about the problem and maybe set a link to this forum thread.

Link to Github:
https://github.com/FAForever/fa/issues
Klick on the button "New Issue"

I have already a clue what happens there. I guess we have fixed this in the next patch.

[KeyBlue]

when you use the default value, the lobby doesn't set the value ScenarioInfo.Options.opt_AutoReclaim, and it stays nil. (unless you manually chose the default option)
In the script this is usually fixed by using something like

Code: Select all

opt_AutoReclaim = ScenarioInfo.Options.opt_AutoReclaim or [default value]

So if you want to adjust the default value of an option, one has to go inside the script and change the default value used there.
So not broken, just stupid.

[Uveso]

@KeyBlue:

and how you explain this:

If I put the default to 6, I the lobby will show the 40% option.

The default value works with number 6 but not with number 7.

[KeyBlue]

@KeyBlue:

and how you explain this:

If I put the default to 6, I the lobby will show the 40% option.

The default value works with number 6 but not with number 7.

You explained this already, no?
The default is matched with the index, so default = 6 for 40% and default = 7 for 50% (this works according to his posts)

Reading the entire thread again:
In both cases (6 and 7) he encountered the problem i explained.
In both cases the lobby showed the correct default option. (resp. 40% and 50%)

So default doesn't work with neither 6 and 7.

[EntropyWins]

I have already a clue what happens there. I guess we have fixed this in the next patch.

Great, let's hope that is the case. Any idea when it will be rolled out?

@KeyBlue: the workaround you describe could work yes, though I really rather avoid it.

Well, i tryed to debug the map, but it has to many errors for a short view. (tryed version 0007)

Yeah I know... the reason I noticed the issue reported here is because I'm working on a new version of the map that is not as broken: https://github.com/JeroenDeDauw/FinalRushPro5

[KeyBlue]

@KeyBlue: the workaround you describe could work yes, though I really rather avoid it.

Do you mean the little code snippet I posted?

Code: Select all

opt_AutoReclaim = ScenarioInfo.Options.opt_AutoReclaim or [default value]

The original map that you linked uses the same workaround though.
See here: https://github.com/JeroenDeDauw/FinalRu ... pt.lua#L92
all those if's do the same thing as i described.

[EntropyWins]

Yes. I've done that now. Reason for avoiding: the information is duplicated in two places. One of which can't easily be modified by whoever is hosting the game without risking desync, unlike modifying the options file, which is fine. Both are not deal breakers, just not nice...