disruptor -personal shield bug

[Ithilis_Quo]

Dirstuptor dont work against personal shield, can it be fixed?

[IceDreamer]

Dirstuptor dont work against personal shield, can it be fixed?

Yeah the team is working on it. I've not been able to find the right place to hook in yet, unfortunately :/

[Sheeo]

It'll be fixed for the next patch release (3641).

[IceDreamer]

Submitted a fix for this one - https://github.com/FAForever/fa/pull/504

[keyser]

Will the fix include damage done to the sheild of harby and obsidian (and sACU)?

[IceDreamer]

Yes. Actually I owe the community an apology for this one, as it should have been foreseen. The way Sheeo and I were able to fix a number of bugs in the personal shield system was to actually get rid of them completely; Personal shields no longer have any collision box whatsoever. Instead, all damage hits the unit collision box, and the OnDamage code checks for an active personal shield and passes the damage along. We never tested with the Shield Disrupter, which, because it now never hits a shield when attacking something like Obsidian, does only 5 damage.

This fix re-works how the Disrupter functions in code. Now, instead of a special shield damage on top of the normal damage of 5, it just has Damage = 1300 and a special AntiShield damage type checked in OnDamage. This means that it no longer does any damage whatsoever to non-shields, but given that it previously did all of 2.5 DPS, it's not much cause for balance concern

[keyser]

well you could have use it to snipe radar from range. But i guess it doesn't impact that much the game.
Having their ability to shoot persona shield is more important

[Ithilis_Quo]

also this problem would have Nomads EMP tanks, who is operating with anti-shield damage. And him Dmg is not ussles as on disruptor. Hmmm Brute would must found some other solution, that can then be implement on faf as well.

[Sheeo]

Not sure if nomads was updated to accommodate the shield damage update for 3636.

Another potential fix would be to give the unit entity itself the SHIELD category, although this needs more investigation.

[IceDreamer]

The correct fix is to do the bloody thing properly. Why the actual weapon is not passed to OnDamage, just the Instigator, I will never know, but it's being really restrictive. I can't actually work out how the existing system even functioned, the logic chain seems to break half-way through!