Disable live replay for "mod == phantomx"

Talk about general things concerning Forged Alliance Forever.

Moderators: FtXCommando, Ze Dogfather

Disable live replay for "mod == phantomx"

Postby BrickedKeyboard » 07 Jan 2015, 08:48

Somewhere in the FAF codebase, there is a server that handles live replay. Somewhere in that code, that server decides whether or not to setup a live replay stream. A single line of code to deny live replay streams if it's a custom game using phantomx would fix the problem where it is trivial for a third party to cheat and tell everyone in a phantom game who the phantoms are.
BrickedKeyboard
Crusader
 
Posts: 26
Joined: 05 Jul 2013, 21:34
Has liked: 0 time
Been liked: 1 time
FAF User Name: PlayerY

Re: Disable live replay for "mod == phantomx"

Postby BrickedKeyboard » 07 Jan 2015, 21:31

Specifically, the field is featured_mod. If the featured_mod is phantomx, no live replays should be permitted. Simple. That also means your code would not have to iterate through the list of mods to make this decision.
BrickedKeyboard
Crusader
 
Posts: 26
Joined: 05 Jul 2013, 21:34
Has liked: 0 time
Been liked: 1 time
FAF User Name: PlayerY

Re: Disable live replay for "mod == phantomx"

Postby Rogueleader89 » 11 Jan 2015, 07:49

Ideally instead of just solving this for phantom it would be nice to have a flag of some sort that mods can set which tells faf whether to make live replays available for it or not, solving potential future issues.
Rogueleader89
Avatar-of-War
 
Posts: 130
Joined: 15 Jan 2014, 08:22
Has liked: 5 times
Been liked: 26 times
FAF User Name: JadeXyan

Re: Disable live replay for "mod == phantomx"

Postby Sheeo » 11 Jan 2015, 12:43

Rogueleader89 wrote:Ideally instead of just solving this for phantom it would be nice to have a flag of some sort that mods can set which tells faf whether to make live replays available for it or not, solving potential future issues.


Indeed, this would be useful.
Support FAF on patreon: https://www.patreon.com/faf?ty=h

Peek at our continued development on github: https://github.com/FAForever
Sheeo
Councillor - Administrative
 
Posts: 1038
Joined: 17 Dec 2013, 18:57
Has liked: 109 times
Been liked: 233 times
FAF User Name: Sheeo


Return to General Discussions

Who is online

Users browsing this forum: No registered users and 1 guest