Client transition - constructive feedback thread

[schwartz1030]

Hi All,

Great work so far on moving this forward. I am testing this for the first time after I recently noticed that the legacy client will be deprecated soon.

Problems so far:
1) First big problem for me is UPnP. I am getting orange Proxy Connection. I have a working UPnP gateway on the system, and I can watch all open UPnP connections. I have other windows software which is successfully opening ports through UPnP and I can see this on my gateway dashboard.

I would love some help diagnosing this. I am running latest Windows 10 Pro. Steam installed SC:FA, Steam Linked. Latest Downlord client (downloaded today). It is possible the old client was also connecting through proxy.

2) Local Replays looks to have a limit (300) that it can read which is understandable, but it loads them in chronological order meaning all the most recent ones are missing. Ideally it should read them in reverse chronological order.

3) On my Windows Taskbar, the client is showing a continuous green wave. Not sure why.

4) Under 1:1 Ranked Match, I can't tell whether the faction icons are selected or unselected? They go really dim (almost unreadable) when I click them, but I have no idea which state is selected/unselected and I don't see any other indications/tooltip.

5) Under Vault/Maps -- it spins forever... Maybe that is the cause of the green wave?

6) I really really really miss the game.pref link under the main menu. You have Mod/Map/Mod and I can find replay from those, but not game.pref.

7) Launching a 1v1 Ranked match triggers a popup saying there is another match available

MINOR UI STUFF (ignore for now unless you're already there):
A) Scroll bars can't be grabbed if window is not maximized because you get the resize instead
B) Unit database is slow scrolling -- was much faster in old client
C) Remembering my game password (EDIT)
D) Graphical identifier in the game tile for password games (EDIT)

KUDOS
* A working Mod Vault!!!!!

OVERALL IMPRESSION:
The features are all here for me to switch. Not sure whether I like the new game screen yet. Tons of better data for sure I just have this feeling I saw more games at a glance in the old client. Have to try it for a while.

EDIT:
Create game is really nice! Big improvement.

[schwartz1030]

LOG entries regarding connectivity:
2019-02-16 16:39:01.749 INFO 30704 --- [JavaFX Application Thread] c.f.c.c.ConnectivityServiceImpl : Opened public UDP socket: 0.0.0.0/0.0.0.0:6112
2019-02-16 16:39:06.661 INFO 30704 --- [pool-2-thread-43] c.f.client.upnp.WeUpnpServiceImpl : Could not find a UPnP capable gateway
2019-02-16 16:39:06.667 INFO 30704 --- [pool-2-thread-43] c.f.c.c.ConnectivityCheckTask : Testing public connectivity of game port: 6112
2019-02-16 16:39:16.780 INFO 30704 --- [Thread-10] c.f.c.c.ConnectivityServiceImpl : Switching to random port for STUN connectivity
2019-02-16 16:39:16.785 INFO 30704 --- [Thread-10] c.f.c.c.ConnectivityServiceImpl : Opened public UDP socket: 0.0.0.0/0.0.0.0:15665
2019-02-16 16:39:17.024 INFO 30704 --- [JavaFX Application Thread] c.f.c.c.ConnectivityServiceImpl : Connectivity check successful, state: STUN, address: 184.145.116.82:15665

[schwartz1030]

It seems the old client was able to connect via UPnP at least in some scenarios according to this log file from yesterday:

Logs from yesterday -- on old client:
2019-02-15 20:20:33,265 INFO fa.upnp UPnP mapping 192.168.123.116:6112
2019-02-15 20:20:33,293 INFO fa.upnp -> UDP mapping of 192.168.123.116:6112 to 184.145.116.82:6112
2019-02-15 20:20:33,296 INFO fa.play Play received arguments: ['/mean', '1505.05', '/deviation', '89.0422', '/country ', 'CA']
2019-02-15 20:20:33,296 INFO fa.game_process Running FA with info: {'uid': 9279586, 'recorder': 'schwartz1030', 'featured_mod': 'faf', 'launched_at': 1550280033.2960877, 'complete': False}

[ZeRen]

I think my client is not working properly on graphic side

pic1.jpg (241.36 KiB) Viewed 4379 times

pic2.jpg (180.04 KiB) Viewed 4379 times

[Bullydozer]

Not sure if it has been said yet, but it would be nice to be able to see what map people are playing/hosting in the player list.

Downlords:
https://imgur.com/a/D2OKx2Q
Original:
https://imgur.com/a/Xy575RH

[HerzogGorky]

"1v1 ranked match availible" notification is pure bullshit. It is much worse than legacy bottom-bar-thingy.

Firstly, there is no way of telling if someone is looking for a ladder game if you missed the notification(e.g. you was afk and came back to play some games, someone might be searching but you didn't see the notif. so you have to just rely on chance).
Secondly, it triggers on starting searching yourself. In other words you hit play and it shows up.
Thirdly it is even worse than original in the way that you see the bar/notification, you hit play and game doesn't start. In legacy client i could just check replay vault to see if someone actually found the game and i was just late on it. The new client i believe doesn't show in-progress replays at all. So when notifications start appearing like mad and im sitting here with a search enabled i know something really wrong is happening. And it happens qute regularly. I am looking for a game for couple of mins and double-triple notifications show up all the time but no game.

Btw is someone from dev team actually reading this thread and write all bugs down or do we have to submit them somewhere?

[relent0r]

I'm getting a 400 on password change attempts.

2019-02-24 08:15:28.347 WARN 6508 --- [JavaFX Application Thread] com.faforever.client.task.TaskService : Task failed

org.springframework.web.client.HttpClientErrorException$BadRequest: 400 Bad Request
at org.springframework.web.client.HttpClientErrorException.create(HttpClientErrorException.java:79) ~[spring-web-5.1.1.RELEASE.jar:5.1.1.RELEASE]
at org.springframework.web.client.DefaultResponseErrorHandler.handleError(DefaultResponseErrorHandler.java:97) ~[spring-web-5.1.1.RELEASE.jar:5.1.1.RELEASE]
at org.springframework.web.client.DefaultResponseErrorHandler.handleError(DefaultResponseErrorHandler.java:79) ~[spring-web-5.1.1.RELEASE.jar:5.1.1.RELEASE]
at com.faforever.client.api.JsonApiErrorHandler.handleError(JsonApiErrorHandler.java:31) ~[downlords-faf-client-0.9.3-beta.jar:0.9.3-beta]
at org.springframework.security.oauth2.client.http.OAuth2ErrorHandler.handleError(OAuth2ErrorHandler.java:172) ~[spring-security-oauth2-2.2.1.RELEASE.jar:na]
at org.springframework.web.client.ResponseErrorHandler.handleError(ResponseErrorHandler.java:63) ~[spring-web-5.1.1.RELEASE.jar:5.1.1.RELEASE]
at org.springframework.web.client.RestTemplate.handleResponse(RestTemplate.java:777) ~[spring-web-5.1.1.RELEASE.jar:5.1.1.RELEASE]
at org.springframework.web.client.RestTemplate.doExecute(RestTemplate.java:735) ~[spring-web-5.1.1.RELEASE.jar:5.1.1.RELEASE]
at org.springframework.security.oauth2.client.OAuth2RestTemplate.doExecute(OAuth2RestTemplate.java:128) ~[spring-security-oauth2-2.2.1.RELEASE.jar:na]
at org.springframework.web.client.RestTemplate.execute(RestTemplate.java:669) ~[spring-web-5.1.1.RELEASE.jar:5.1.1.RELEASE]
at org.springframework.web.client.RestTemplate.postForEntity(RestTemplate.java:444) ~[spring-web-5.1.1.RELEASE.jar:5.1.1.RELEASE]
at com.faforever.client.api.FafApiAccessorImpl.post(FafApiAccessorImpl.java:506) ~[downlords-faf-client-0.9.3-beta.jar:0.9.3-beta]
at com.faforever.client.api.FafApiAccessorImpl.changePassword(FafApiAccessorImpl.java:284) ~[downlords-faf-client-0.9.3-beta.jar:0.9.3-beta]
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:na]
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[na:na]
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[na:na]
at java.base/java.lang.reflect.Method.invoke(Unknown Source) ~[na:na]
at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:343) ~[spring-aop-5.1.1.RELEASE.jar:5.1.1.RELEASE]
at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:206) ~[spring-aop-5.1.1.RELEASE.jar:5.1.1.RELEASE]
at com.sun.proxy.$Proxy61.changePassword(Unknown Source) ~[na:na]
at com.faforever.client.user.ChangePasswordTask.call(ChangePasswordTask.java:60) ~[downlords-faf-client-0.9.3-beta.jar:0.9.3-beta]
at com.faforever.client.user.ChangePasswordTask.call(ChangePasswordTask.java:17) ~[downlords-faf-client-0.9.3-beta.jar:0.9.3-beta]
at javafx.graphics/javafx.concurrent.Task$TaskCallable.call(Unknown Source) ~[javafx.graphics:na]
at java.base/java.util.concurrent.FutureTask.run(Unknown Source) ~[na:na]
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) ~[na:na]
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) ~[na:na]
at java.base/java.lang.Thread.run(Unknown Source) ~[na:na]

[Plasma_Wolf]

How do I stop this horrid notification thing from happening?

[tatsu]

Hi All,

Great work so far on moving this forward. I am testing this for the first time after I recently noticed that the legacy client will be deprecated soon.

Problems so far:
1) First big problem for me is UPnP. I am getting orange Proxy Connection. I have a working UPnP gateway on the system, and I can watch all open UPnP connections. I have other windows software which is successfully opening ports through UPnP and I can see this on my gateway dashboard.

I would love some help diagnosing this. I am running latest Windows 10 Pro. Steam installed SC:FA, Steam Linked. Latest Downlord client (downloaded today). It is possible the old client was also connecting through proxy.

hey I think you can fix this with port forwarding.

you had the same connectivity on python client, it just wasn't able to tell you :
try this guide from here :

Code: Select all

https://youtu.be/4B6EsXtL8C0?t=1000

How do I stop this horrid notification thing from happening?

i don't have this but I'm using linux, have you tried fiddling with the notifications options in the settings, perhaps turning off notifications entirely?

[ax0lotl]

Hi,

If support is stopped of the old client, then announce it in What's new. The forum is not read by most people. This should actually have been done some time ago already.

If the old client is not supported anymore, then the new one is not a beta anymore, right? Rename the exe to download to something not so cryptical and without beta in the name (not dfc_windows-x64_0_9_3-beta.exe).
The name makes me suspicious that the new client requires a 64 bit OS, isn't that a bit too limiting?
If the Java client is the official client, then don't call it Downlords client anymore, rename the Git repository if possible (now https://github.com/FAForever/downlords-faf-client).

Suggestion for a layout of the News message below. Please adapt, ignore, whatever, but post something. Try to in the text not be technical, explain what the impact will be and try to focus on the positive rather than the negative.

-------
Dear commanders,

SInce a while we have been developing and maintaining two FAF clients.
As of end of March we will stop support of the old client (the Python client). This means that over time functionality will break and that no bugfixes will be released anymore.

The new client (the Java client) will continuously be improved and expanded. For those who don't run it yet, it can be downloaded from https://faforever.com/client.
The new client already has many features not available before:
[....]

We would like to thank the developers of the original Python client, who have always been there for us, such as [...]

If you encounter issues or problems with the new client, post them at Github or in the Tech Support forum.

The original announcement of this change can be found here on the forum.
If you have any suggestions for improvement of the new client, please post them in this forum thread.