Revert adding Energy Storage to PGen Hotbuild Bind?

Talk about general things concerning Forged Alliance Forever.

Moderators: FtXCommando, Ze Dogfather

Revert adding Energy Storage to PGen Hotbuild Bind?

Postby IceDreamer » 20 May 2017, 23:42

Seems there's a little disagreement here. I didn't see any harm adding it when it was suggested, just seemed handy, but hey I've been wrong before!

https://github.com/FAForever/fa/issues/2008

http://www.strawpoll.me/13007915
IceDreamer
Supreme Commander
 
Posts: 2607
Joined: 27 Dec 2011, 07:01
Has liked: 138 times
Been liked: 488 times

Re: Revert adding Energy Storage to PGen Hotbuild Bind?

Postby JaggedAppliance » 20 May 2017, 23:48

I'll just copy paste what I said on github:
You can already bind energy storage to a hotkey. It is rarely built. It is also the same size as a t1 pgen so it is very easy to miss your mistake if you start building them. The pgen hotkey is one of the most often used hotkeys in the game so it doesn't make sense to have some like energy storage mixed in there, its only relation is that it has energy in the name.

If you do accidentally build storage early and don't catch it straight away you lose the game.
"and remember, u are a noob, u don’t have any rights to disagree" - Destructor

My Youtube channel with casts > https://www.youtube.com/c/jaggedappliance
My Twitch > https://www.twitch.tv/jaggedappliance
JaggedAppliance
Councillor - Balance
 
Posts: 641
Joined: 08 Apr 2015, 14:45
Has liked: 734 times
Been liked: 313 times
FAF User Name: JaggedAppliance

Re: Revert adding Energy Storage to PGen Hotbuild Bind?

Postby Farmsletje » 20 May 2017, 23:57

i didn't have any room for storage hotkey so i like it
FtXCommando wrote:
need to give him some time to blossom into an aids flower
Farmsletje
Contributor
 
Posts: 1116
Joined: 14 Sep 2016, 18:38
Has liked: 383 times
Been liked: 452 times
FAF User Name: Farmsletje

Re: Revert adding Energy Storage to PGen Hotbuild Bind?

Postby PhilipJFry » 21 May 2017, 00:01

Farmsletje wrote:i didn't have any room for storage hotkey so i like it

this is basically the reason why i made that PR
i tried to make a mod to create a hotkey for the old pgen hotkey after 2 ppl mentioned that they liked it better they way it was before but i can't code ...
Spoiler: show
a system where the user can create hotkeys in the game through the ui would be amazing but that would require a lot of work
Last edited by PhilipJFry on 21 May 2017, 00:03, edited 1 time in total.
cats>dogs
post logs
User avatar
PhilipJFry
Supreme Commander
 
Posts: 2635
Joined: 23 Mar 2016, 21:16
Location: Austria
Has liked: 232 times
Been liked: 348 times
FAF User Name: PhilipJFry

Re: Revert adding Energy Storage to PGen Hotbuild Bind?

Postby JaggedAppliance » 21 May 2017, 00:02

Most people have e storage as a template so they would not save a key with this. You can also set energy storage as its own hotkey as well already.
"and remember, u are a noob, u don’t have any rights to disagree" - Destructor

My Youtube channel with casts > https://www.youtube.com/c/jaggedappliance
My Twitch > https://www.twitch.tv/jaggedappliance
JaggedAppliance
Councillor - Balance
 
Posts: 641
Joined: 08 Apr 2015, 14:45
Has liked: 734 times
Been liked: 313 times
FAF User Name: JaggedAppliance

Re: Revert adding Energy Storage to PGen Hotbuild Bind?

Postby PhilipJFry » 21 May 2017, 00:03

JaggedAppliance wrote:Most people have e storage as a template so they would not save a key with this. You can also set energy storage as its own hotkey as well already.

you have any data to back that up?
and even if what is the difference between going through all pgens to get to the storage instead of using a template hotkey to do it?
using one key just for the e storage is kinda dumb considering that you don't build them a lot
Spoiler: show
to me this issue seems more of an "i don't like change so i want the old thing back" to be honest
cats>dogs
post logs
User avatar
PhilipJFry
Supreme Commander
 
Posts: 2635
Joined: 23 Mar 2016, 21:16
Location: Austria
Has liked: 232 times
Been liked: 348 times
FAF User Name: PhilipJFry

Re: Revert adding Energy Storage to PGen Hotbuild Bind?

Postby Farmsletje » 21 May 2017, 00:08

What's the downside to this btw?
FtXCommando wrote:
need to give him some time to blossom into an aids flower
Farmsletje
Contributor
 
Posts: 1116
Joined: 14 Sep 2016, 18:38
Has liked: 383 times
Been liked: 452 times
FAF User Name: Farmsletje

Re: Revert adding Energy Storage to PGen Hotbuild Bind?

Postby Turinturambar » 21 May 2017, 00:10

What's the downside to this btw?


ppl Building accidental Storages at the start of the game -> instaloose
Turinturambar
Avatar-of-War
 
Posts: 288
Joined: 01 Jul 2015, 20:38
Has liked: 1 time
Been liked: 91 times
FAF User Name: 竜宮レナ

Re: Revert adding Energy Storage to PGen Hotbuild Bind?

Postby JaggedAppliance » 21 May 2017, 00:11

PhilipJFry wrote:
JaggedAppliance wrote:Most people have e storage as a template so they would not save a key with this. You can also set energy storage as its own hotkey as well already.

you have any data to back that up?
and even if what is the difference between going through all pgens to get to the storage instead of using a template hotkey to do it?
using one key just for the e storage is kinda dumb considering that you don't build them a lot
Spoiler: show
to me this issue seems more of an "i don't like change so i want the old thing back" to be honest

No need to put it as you do at the end, you should at least listen. Putting something that's built once, if it all, in most games on the same hotkey that is one of the most used is dumb when accidentally building the wrong thing which you almost never want can kill you. E storage is not useful enough to be put with pgens. The only reason it's put there is because it has to do with energy and it's not on another hotkey. That's the logic. I saw it happen twice already that people built storage instead of pgens, it will cost you a game.
"and remember, u are a noob, u don’t have any rights to disagree" - Destructor

My Youtube channel with casts > https://www.youtube.com/c/jaggedappliance
My Twitch > https://www.twitch.tv/jaggedappliance
JaggedAppliance
Councillor - Balance
 
Posts: 641
Joined: 08 Apr 2015, 14:45
Has liked: 734 times
Been liked: 313 times
FAF User Name: JaggedAppliance

Re: Revert adding Energy Storage to PGen Hotbuild Bind?

Postby PhilipJFry » 21 May 2017, 00:38

I just talked to keyblue and he was so nice to make a mod to overwrite the current pgen hotbuild hotkey to remove the e-storage
so if you want to use that until the change is reverted i'll just add the mod to this post
Attachments
SpecialHotkey.zip
(1.81 KiB) Downloaded 139 times
cats>dogs
post logs
User avatar
PhilipJFry
Supreme Commander
 
Posts: 2635
Joined: 23 Mar 2016, 21:16
Location: Austria
Has liked: 232 times
Been liked: 348 times
FAF User Name: PhilipJFry

Next

Return to General Discussions

Who is online

Users browsing this forum: No registered users and 1 guest