Observers button abuse

Talk about general things concerning Forged Alliance Forever.

Moderators: FtXCommando, Ze Dogfather

Observers button abuse

Postby tatsu » 22 Feb 2017, 19:22

I think clicking on the "observer" button when you are observer should not display any message in the chat box :
Image

as you can see it can be abused to prevent chatting.
User avatar
tatsu
Supreme Commander
 
Posts: 1553
Joined: 02 Jul 2012, 21:26
Has liked: 1952 times
Been liked: 171 times
FAF User Name: tatsu

Re: Observers button abuse

Postby lextoc » 22 Feb 2017, 19:41

I believe only you can see that message, correct me if I'm mistaken.
I'm watching you!
User avatar
lextoc
Supreme Commander
 
Posts: 1057
Joined: 17 Mar 2013, 18:08
Has liked: 287 times
Been liked: 227 times
FAF User Name: lextoc

Re: Observers button abuse

Postby tatsu » 22 Feb 2017, 20:16

lextoc wrote:I believe only you can see that message, correct me if I'm mistaken.

everyone can

in this case that's 12 people and noone can see chat

(did you mean host? because as you can see in the screen i wasn't host)
User avatar
tatsu
Supreme Commander
 
Posts: 1553
Joined: 02 Jul 2012, 21:26
Has liked: 1952 times
Been liked: 171 times
FAF User Name: tatsu

Re: Observers button abuse

Postby KeyBlue » 22 Feb 2017, 20:27

Should be easy to fix.
Already put a PR on github, only needs some testing. (but should work)
User avatar
KeyBlue
Priest
 
Posts: 403
Joined: 28 Jan 2016, 01:06
Has liked: 140 times
Been liked: 93 times
FAF User Name: KeyBlue

Re: Observers button abuse

Postby Farmsletje » 22 Feb 2017, 20:58

ghehehe
FtXCommando wrote:
need to give him some time to blossom into an aids flower
Farmsletje
Contributor
 
Posts: 1116
Joined: 14 Sep 2016, 18:38
Has liked: 383 times
Been liked: 452 times
FAF User Name: Farmsletje

Re: Observers button abuse

Postby Farmsletje » 24 Feb 2017, 05:25

KeyBlue wrote:Should be easy to fix.
Already put a PR on github, only needs some testing. (but should work)

Let me add something to that.

Is it possible to make the lobby chat not jump back down to the latest message whenever someone posts something?
FtXCommando wrote:
need to give him some time to blossom into an aids flower
Farmsletje
Contributor
 
Posts: 1116
Joined: 14 Sep 2016, 18:38
Has liked: 383 times
Been liked: 452 times
FAF User Name: Farmsletje

Re: Observers button abuse

Postby tatsu » 24 Feb 2017, 14:30

Farmsletje wrote:Is it possible to make the lobby chat not jump back down to the latest message whenever someone posts something?

Image
User avatar
tatsu
Supreme Commander
 
Posts: 1553
Joined: 02 Jul 2012, 21:26
Has liked: 1952 times
Been liked: 171 times
FAF User Name: tatsu

Re: Observers button abuse

Postby KeyBlue » 27 Feb 2017, 01:01

Okay i just looked at the code and it looks like i could easily remove a line of code, so it doesn't jump down.
I don't know the full implications of this though. (could be you would have to manualy scroll down for each message)

But in the obvious situation where you scrolled up a bit and then you forget to scroll down, you could miss all the following incoming messages.
So suggest a nice way how to signal a player that there is a new message he hasn't read yet.

And if its good and i am able to do it then i'll try to make your suggestion happen.
User avatar
KeyBlue
Priest
 
Posts: 403
Joined: 28 Jan 2016, 01:06
Has liked: 140 times
Been liked: 93 times
FAF User Name: KeyBlue

Re: Observers button abuse

Postby tatsu » 03 Mar 2017, 20:20

KeyBlue wrote:Okay i just looked at the code and it looks like i could easily remove a line of code, so it doesn't jump down.
I don't know the full implications of this though. (could be you would have to manualy scroll down for each message)

But in the obvious situation where you scrolled up a bit and then you forget to scroll down, you could miss all the following incoming messages.
So suggest a nice way how to signal a player that there is a new message he hasn't read yet.

And if its good and i am able to do it then i'll try to make your suggestion happen.

a sound like the message sound from faf but another sound
User avatar
tatsu
Supreme Commander
 
Posts: 1553
Joined: 02 Jul 2012, 21:26
Has liked: 1952 times
Been liked: 171 times
FAF User Name: tatsu

Re: Observers button abuse

Postby Farmsletje » 03 Mar 2017, 20:42

A little arrow pointing down
FtXCommando wrote:
need to give him some time to blossom into an aids flower
Farmsletje
Contributor
 
Posts: 1116
Joined: 14 Sep 2016, 18:38
Has liked: 383 times
Been liked: 452 times
FAF User Name: Farmsletje

Next

Return to General Discussions

Who is online

Users browsing this forum: No registered users and 1 guest