Can we (aka the coding monkeys) fix Janus bombers?

[Sovietpride]

https://youtu.be/Jo3h4AsLrMg?t=1347

Better described in motion and in game, rather than with words.

TLDR: wtf is up with this targetting that they can miss structures...?

[keyser]

thing is i don't know how to reproduce it on a common pattern...
maybe it's due to change in elevation, like for T4 bomber not being able to drop everytime.

[Crotalus]

Code is here:
https://github.com/FAForever/fa/blob/de ... ration.lua

Seems like the one who implemented the custom ballistic calculations forgot that the unit dropping the bomb can have velocity on the y-axis

[IceDreamer]

3652 improved them a little, by making sure the spread of bombs hit the target centre, rather than with one end. However, that only works when the bomb is already on target, what you show is something else, something nobody has been able to fix so far. I think Crotalus is right about the lack of Y axis influence being the problem, or part of it, but the actual maths of that code is beyond me at the moment. It's some pretty complex mechanics.

EDIT: Evidence of the improvement is seen at 23:02 in the OPs video, you can see how the fire area has the targeted unit at the very middle. Before 3652, that fire would have had the unit at one end.

EDIT2: Yeah the earlier bombers which miss so badly are coming down off the cliff/hill. This makes it even more likely Crotalus is on to something.

[Crotalus]

Took a look at it now, seems like multiple bombs didn't take y-position change in consideration.

Video of running the replay with refactored ballistic code:
https://www.youtube.com/watch?v=2RSXpXxslA8

PR on github
https://github.com/FAForever/fa/pull/1274

[CookieNoob]

PATCH IT NOW xD

finally! if this really works now then UEF t2 air would be not as worse at it was before

[Ithilis_Quo]

this carpet bombing looks amazing.