Forged Alliance Forever

Re: Running code when a unit is created

2018-09-15T21:25:01+02:00

No problem! Glad I was able to help someone else for a change.
The second if clause is a leftover from when the first if clause was a bit wider (before I learned that "categories._" can contain an actual name of a unit, not strictly categories themselves and I didn't then delete the second, now redundant if clause, because...if it works why touch it. Also because i went so far and wide with my map script (multiple different survival waves depending on numerous variables, for example like above if Paragon is built, lot's of tweaking on boss units etc)...was no time to beautify the well working pieces of code - leave it if it works, move on to the next thing. Also cause I am a noob learn-it-yourself coder.

As for double negations, I had some trouble running non - negation script, for example a simple "if a mod is present -then" would not be detected for some reason, but "if if not (a mod is not present) - then" would work. No idea why.
Again, if the double negative works...if it ain't broken, don't fix it

Anyways...enough rant.

Statistics: Posted by DDDX — 15 Sep 2018, 21:25

Re: Running code when a unit is created

2018-09-15T13:33:07+02:00

Thanks for sharing DDDX! I did not know GetListOfUnits and have some good uses for it.

Looks like you have a double negation in your inner if predicate. And is the one above really needed given you already filter on categories.xab1401? Finally, if you do not use the key in a for loop, I believe it is convention to name it _.

Statistics: Posted by EntropyWins — 15 Sep 2018, 13:33

Re: Running code when a unit is created

2018-09-03T16:01:31+02:00

I use this for my "is Paragon built" script:

Code:: for x, army in ListArmies() do if (army == "ARMY_1" or army == "ARMY_2" or army == "ARMY_3" or army == "ARMY_4" or army == "ARMY_5" or army == "ARMY_6") then List = GetArmyBrain(army):GetListOfUnits(categories.xab1401, false, true) for k, unit in List do if (unit:GetUnitId() == 'xab1401') then if not (unit:GetFractionComplete() ~= 1) then

the last segment is to let the map know the unit is completed and not merely being built

Statistics: Posted by DDDX — 03 Sep 2018, 16:01

Re: Running code when a unit is created

2018-08-21T23:38:01+02:00

No, you must hook that function. This function is the event.

Statistics: Posted by Uveso — 21 Aug 2018, 23:38

Re: Running code when a unit is created

2018-08-21T18:43:40+02:00

Yeah sure, so forget about hooking the that function. That is not what I am asking about. I'm asking if there is a way to run code when a unit gets created. Is there seriously no event of sorts for that?

Statistics: Posted by EntropyWins — 21 Aug 2018, 18:43

Re: Running code when a unit is created

2018-08-21T18:27:17+02:00

its no question if you should, you can't.

Unitblueprints are initalized inside blueprint.lua and will be registered inside the c-engine there.

if you now change the blueprint in your mapscript, it will not be registered inside the c-engine.

And woops desync...

[Edit]
(all c-engine commands will get the old unit data, but if you read the blueprint itself you will get the new data.
And this is only working local, not in multiplayer)

Statistics: Posted by Uveso — 21 Aug 2018, 18:27

Re: Running code when a unit is created

2018-08-21T17:49:17+02:00

I'm going to assume you are saying that hooking that function is not something a map script should be able to do. If on the other hand you are saying that a map script should not be able to react to an "unit created" even, then my reaction is WHY THE FIRGATE NOT?!!! Since this is super useful for many things. For instance to apply health buffs, to bind expiry timers, to remove wreckages, etc.

Statistics: Posted by EntropyWins — 21 Aug 2018, 17:49

Re: Running code when a unit is created

2018-08-21T17:40:29+02:00

Cause it's not something that the map script should be able to do.

Statistics: Posted by speed2 — 21 Aug 2018, 17:40

Re: Running code when a unit is created

2018-08-21T17:17:26+02:00

Hooking that function is not possible in a map script. So I am still looking for a way to do this.

The lua script I linked in my post also has a number of issues, with one of them maybe not fixable. Hence all the more reason to have a sane existing way to react to unit creation.

Statistics: Posted by EntropyWins — 21 Aug 2018, 17:17

Re: Running code when a unit is created

2018-08-18T09:06:03+02:00

Hooking this function https://github.com/FAForever/fa/blob/de ... t.lua#L155

Statistics: Posted by speed2 — 18 Aug 2018, 09:06

Running code when a unit is created

2018-08-18T12:36:48+02:00

I'd like a way to run lua code when a unit gets created. In a map script. Something like this function:

oncreated.png

I've been looking through quite a lot of the FA/FAF lua code and have not found anything providing such functionality. Is there really no way of doing this?

Of course there is one way... which is what I did here https://pastebin.com/KBM72wBv . Having to loop through all units and seeing if there is a new one every tick is quite stupid though, especially if the game already provides a more sane way of reacting to the unit creation event.

Statistics: Posted by EntropyWins — 18 Aug 2018, 08:16