Forged Alliance Forever

Re: The Ugly next Lobby 2.6.0

2015-01-29T02:55:47+02:00

To be clear Xinnony, we have nothing against you, or your work. Having said that, it's not productive to do what you have been doing. The problem with the things you've been saying is that they don't make any sense at all. Now, I appreciate that there is a language barrier in play here, but even so, every comment you've made for the past few days has given me an impression of incomprehensible raging.

The correct way to do it is to make yourself understood, and to point out a legitimate concern about what's going on.

Statistics: Posted by IceDreamer — 29 Jan 2015, 02:55

Re: The Ugly next Lobby 2.6.0

2015-01-29T02:35:44+02:00

FYI: https://github.com/FAForever/fa/pull/429

So, we've established that these functions are never used anywhere. And I really mean "anywhere": I've scanned FAF code, GPG code, and every mod in the mod database. As such, we can definitely remove these without *breaking* anything. But won't these functions come in useful for future work? Isn't this making things harder for future developers?

Let's talk about each deleted function in turn, and see why that's not the case.

CreateHorzScrollbarFor
Yes, that's actually what it's called."Horz" not "Horiz".
The scrollbar class provides a far more concise way to create horizontal scrollbars. (which explains how we can still have horizontal scrollbars without this function).

CreateSequentialFilenameTable
Considered harmful, essentially.
This is a utility function that, basically, makes a nice simple way to create a sequential list of filenames. The idea is this is useful for loading frames of an animation, or suchlike.
The approach used, though, is kinda dangerously inefficient. If you need this functionality it's not a big deal to implement it yourself, and you'll definitely do a better job of it than whoever wrote this function.

CreateBox
The new Border (and related NinePatch) classes, found in ninepatch.lua, provide a much more versatile and performant way to draw boxes and dynamically-resizing borders around things (they form the basis of the swanky new dialogs, for one thing).

CreateTextBox/SetTextBoxText
These provide a way to get textbox-like behaviour using an ItemList.
Don't do that: we have actual textboxes you can use! They work much better than ItemLists, and don't have weird mouse behaviour for you to worry about.

To sum up: I deleted a bunch of code nobody cares about, and that might tempt future developers into doing something the wrong way. Then you threw a screaming hissy fit. Again.

Statistics: Posted by ckitching — 29 Jan 2015, 02:35

Re: The Ugly next Lobby 2.6.0

2015-01-28T21:31:38+02:00

LOL, I would not put my comment would've done something stupid again, like all previous.

Statistics: Posted by Xinnony — 28 Jan 2015, 21:31

Re: The Ugly next Lobby 2.6.0

2015-01-28T21:13:05+02:00

Xinnony wrote:
When you go to understand that he makes that some shit, that will be too late.
Given that deleted him my comments all the time, I just inform that without my check, the words which use the horizontal scrollbars would not just have more worked.
The purpose being to simplify of development in the new to develop, it fabulous to develop to prefer to delete again and again useless functions for him.
That touches no more than the maintaining lobby but all the games in itself.
He becomes worse and worse ... it is disappointing.

Edit : Too late, my two comment is removed ...

You're not making sense and being counterproductive with personal attacks, so I'm deleting your comments on github to keep a high signal to noise ratio on there.

FYI your concerns were shared and adressed in this commit https://github.com/FAForever/fa/commit/1cef12aae7475a98b640af770a7343f4942caef7.

Statistics: Posted by Sheeo — 28 Jan 2015, 21:13

Re: The Ugly next Lobby 2.6.0

2015-01-28T21:02:02+02:00

When you go to understand that he makes that some shit, that will be too late.
Given that deleted him my comments all the time, I just inform that without my check, the words which use the horizontal scrollbars would not just have more worked.
The purpose being to simplify of development in the new to develop, it fabulous to develop to prefer to delete again and again useless functions for him.
That touches no more than the maintaining lobby but all the games in itself.
He becomes worse and worse ... it is disappointing.

Edit : Too late, my two comment is removed ...

Statistics: Posted by Xinnony — 28 Jan 2015, 21:02

Re: The Ugly next Lobby 2.6.0

2015-01-21T03:02:28+02:00

Statistics: Posted by Xinnony — 21 Jan 2015, 03:02

Re: The Ugly next Lobby 2.6.0

2015-01-21T02:34:26+02:00

IceDreamer wrote:
Xinnony your problem solving is ready to go in! All Chris did was take some of it from your PR and split it up for you

IceDreamer's right, you know: PRs #373 and #374 were spawned from the code review I did on your PR. #374 even includes one of your commits verbatim (unfortunately much of the rest ended up being rewritten, but with significant inspiration from your earlier work).

Xinnony wrote:
I try to solve some problems, but we still shit above me again.
You can request on github and with a little luck instead of gun the script it will be be fixed.

File a bug report, either on GitHub or on the "FAF tech support" forum here (from which it'll usually find its way to GitHub within a day), and it'll get the attention it deserves. I think we've got all the current regressions in the tracker now (and several of them fixed in trunk: hooray!)

Throwing a tantrum on the forum or, (as you did a few hours ago) closing all your bug reports on GitHub is not helpful; it just makes the rest of the team have to take time away from doing useful work to deal with it.

If you don't think Sheeo is doing an adequate job of reviewing patches, review them yourself. That is literally what GitHub is *for*. Go through them with a fine toothcomb and pick out every minuscule mistake you can find. You'd be contributing usefully to the development of the project, helping to keep the regression rate down, and helping to educate other contributors about subtleties they may have missed.
When I did this to you, you seemed to misunderstand and got angry.

Statistics: Posted by ckitching — 21 Jan 2015, 02:34

Re: The Ugly next Lobby 2.6.0

2015-01-16T23:27:56+02:00

Xinnony wrote:
I try to solve some problems, but we still shit above me again.
You can request on github and with a little luck instead of gun the script it will be be fixed.

Xinnony your problem solving is ready to go in! All Chris did was take some of it from your PR and split it up for you

There are some bugs left still, hopefully they can all be ironed out once Sheeo's exams are over.

Statistics: Posted by IceDreamer — 16 Jan 2015, 23:27

Re: The Ugly next Lobby 2.6.0

2015-01-16T23:05:31+02:00

I try to solve some problems, but we still shit above me again.
You can request on github and with a little luck instead of gun the script it will be be fixed.

Statistics: Posted by Xinnony — 16 Jan 2015, 23:05

Re: The Ugly next Lobby 2.6.0

2015-01-16T20:55:57+02:00

I dont know the technical details, but in my experience hosting became more difficult than before
1. The difference between number of selectable spots and the real spots on the map makes it unnecessarily complicated to switch players, pls restore that.
2. I often experience that the spot by a kicked player can not be correctly taken by an observer, thats a real problem and that wasnt there before
3. Observers are sometimes not shown in the lobby, even though they are there, and causing connection problems between players. also new.

Statistics: Posted by ABSTRACT — 16 Jan 2015, 20:55

Re: The Ugly next Lobby 2.6.0

2015-01-06T01:50:14+02:00

I not see, you have a files now, you can add

Statistics: Posted by Xinnony — 06 Jan 2015, 01:50

Re: The Ugly next Lobby 2.6.0

2015-01-05T23:07:37+02:00

Xinnony wrote:
IceDreamer wrote:Same for you Xinnony, the sources you used to create the awesome lobby visuals would be great for the community to have access to.

Yes i have the original PSD

Would you mind making them public here? https://github.com/aeoncleanse/Art-Assets

Statistics: Posted by IceDreamer — 05 Jan 2015, 23:07

Re: The Ugly next Lobby 2.6.0

2015-01-05T20:46:41+02:00

while it brightens my winter days to see grown man pull out each others hair like a bunch of preschool girls;
how about you work together and fix the remaining bugs. Since in your immature accusations you have
almost by accident already made a list of known problems, i suggest you start with those.

Statistics: Posted by rootbeer23 — 05 Jan 2015, 20:46

Re: The Ugly next Lobby 2.6.0

2015-01-05T20:24:40+02:00

IceDreamer wrote:
Ze_PilOt - Since you seem to be watching this thread... I took your casual advice from an earlier post somewhere and there's now a repo for art asset masters like photoshop, gimp or whatever original source material was used. Do you have any such files lying around, such as from creating Galactic War, or just the general client UI, that you could upload so that we have every available resource?

Same for you Xinnony, the sources you used to create the awesome lobby visuals would be great for the community to have access to.

I don't think I have PSD sources for GW - it's mostly textures directly rendered in jpg/png. AFAIK they are not under repository, I hope they are still on the new server...

Statistics: Posted by Ze_PilOt — 05 Jan 2015, 20:24

Re: The Ugly next Lobby 2.6.0

2015-01-05T19:38:34+02:00

IceDreamer wrote:
Same for you Xinnony, the sources you used to create the awesome lobby visuals would be great for the community to have access to.

Yes i have the original PSD

Statistics: Posted by Xinnony — 05 Jan 2015, 19:38