Forged Alliance Forever

Re: New Lobby Awaiting Approval

2014-11-21T19:10:01+02:00

Xinnony wrote:
You have Access now.

Thanks. I won't have time for it until after we have the 0.11-pre lobby release live, this will allow us to really easily test your new lobby as well

Statistics: Posted by Sheeo — 21 Nov 2014, 19:10

Re: New Lobby Awaiting Approval

2014-11-21T18:56:01+02:00

You have Access now.

Statistics: Posted by Xinnony — 21 Nov 2014, 18:56

Re: New Lobby Awaiting Approval

2014-11-21T18:51:06+02:00

Xinnony wrote:
There was no conflict, but by dint of waiting there to be had ...

And now how can resolve and see the conflic caused by other work ?

And i see the comment and fixed it.

Its been like with Zepilot, I do a pull request, and other work going on in front of me and create conflict ... and is my fault ! ...

And the LobbyFA has nothing to do with a balance patch (3626), is different.

The lobby is shipped as part of the faf game code, its thus in the same release cycle.

Give me push access to your repository and I'll update your PR for you.

Statistics: Posted by Sheeo — 21 Nov 2014, 18:51

Re: New Lobby Awaiting Approval

2014-11-21T18:40:53+02:00

There was no conflict, but by dint of waiting there to be had ...

And now how can resolve and see the conflic caused by other work ?

And i see the comment and fixed it.

Its been like with Zepilot, I do a pull request, and other work going on in front of me and create conflict ... and is my fault ! ...

And the LobbyFA has nothing to do with a balance patch (3626), is different.

Statistics: Posted by Xinnony — 21 Nov 2014, 18:40

Re: New Lobby Awaiting Approval

2014-11-21T18:30:02+02:00

Xinnony wrote:
I do not understand.

Who can add my Lobby 2.5 ?

We do that by working together. In your current pull request, there are merge conflicts. If you resolve that and the comments listed in the PR, I'll merge it for patch 3636.

Statistics: Posted by Sheeo — 21 Nov 2014, 18:30

Re: New Lobby Awaiting Approval

2014-11-21T18:22:26+02:00

I do not understand.

Who can add my Lobby 2.5 ?

If need wait 4 month as with Zep, i stop devlop new versions.

Statistics: Posted by Xinnony — 21 Nov 2014, 18:22

Re: New Lobby Awaiting Approval

2014-11-21T18:15:46+02:00

Xinnony wrote:
Possible to merge and upload the Lobby 2.5 ?

https://github.com/FAForever/fa/pull/105

As you can see on github, it's not trivially mergeable. If you could update your pull request, that would make it easier

Statistics: Posted by Sheeo — 21 Nov 2014, 18:15

Re: New Lobby Awaiting Approval

2014-11-21T18:14:50+02:00

Xinnony wrote:
Possible to merge and upload the Lobby 2.5 ?

https://github.com/FAForever/fa/pull/105

Probably best to merge my FAF+Coop branch first, then this.

Statistics: Posted by IceDreamer — 21 Nov 2014, 18:14

Re: New Lobby Awaiting Approval

2014-11-21T17:16:25+02:00

Possible to merge and upload the Lobby 2.5 ?

https://github.com/FAForever/fa/pull/105

Statistics: Posted by Xinnony — 21 Nov 2014, 17:16

Re: New Lobby Awaiting Approval

2014-11-13T22:04:08+02:00

If you "somehow" select the exe, we also correct it now

Statistics: Posted by Dragonfire — 13 Nov 2014, 22:04

Re: New Lobby Awaiting Approval

2014-11-13T21:58:42+02:00

eXcalibur wrote:
that was fast.
thanks a lot for your effort. i know this is not the right place.

i looked at the code and did not understand everything. is it possible to enter the path to "ForgedAlliance.exe" file instead of the installation folder, e.g.: "D:/Games/Supreme Commander Forged Alliance/bin/ForgedAlliance.exe" instead of "D:/Games/Supreme Commander Forged Alliance"?

if this is NOT possible, i recommend the following change in src/fa/updater.py:
old:
Code:
"FAF needs a version of Supreme Commander: Forged Alliance to launch games and replays. Please choose the installation you wish to use. The following versions are equally supported:3596(Retail version) 3599 (Retail patch) 3603beta (GPGnet beta patch) 1.6.6 (Steam Version) FAF doesn't modify your existing files. Select folder:")

new:
Code:
"FAF needs a version of Supreme Commander: Forged Alliance to launch games and replays. Please choose the installation folder (and NOT the SupremeCommander.exe or ForgedAlliance.exe file) you wish to use. The following versions are equally supported:3596(Retail version) 3599 (Retail patch) 3603beta (GPGnet beta patch) 1.6.6 (Steam Version) FAF doesn't modify your existing files. Select folder:")

With the current dialog you can't select the .exe file. If you somehow select bin/ instead of the base directory, we'll correct that now.

Statistics: Posted by Sheeo — 13 Nov 2014, 21:58

Re: New Lobby Awaiting Approval

2014-11-13T20:35:47+02:00

that was fast.
thanks a lot for your effort. i know this is not the right place.

i looked at the code and did not understand everything. is it possible to enter the path to "ForgedAlliance.exe" file instead of the installation folder, e.g.: "D:/Games/Supreme Commander Forged Alliance/bin/ForgedAlliance.exe" instead of "D:/Games/Supreme Commander Forged Alliance"?

if this is NOT possible, i recommend the following change in src/fa/updater.py:
old:

Code:

"FAF needs a version of Supreme Commander: Forged Alliance to launch games and replays. 

Please choose the installation you wish to use.

The following versions are equally supported:3596(Retail version)
3599 (Retail patch)
3603beta (GPGnet beta patch)
1.6.6 (Steam Version)
FAF doesn't modify your existing files.

Select folder:")

new:

Code:

"FAF needs a version of Supreme Commander: Forged Alliance to launch games and replays. 

Please choose the installation folder (and NOT the SupremeCommander.exe or ForgedAlliance.exe file) you wish to use.

The following versions are equally supported:3596(Retail version)
3599 (Retail patch)
3603beta (GPGnet beta patch)
1.6.6 (Steam Version)
FAF doesn't modify your existing files.

Select folder:")

Statistics: Posted by eXcalibur — 13 Nov 2014, 20:35

Re: New Lobby Awaiting Approval

2014-11-13T13:51:44+02:00

eXcalibur wrote:
i have a suggestion:

in the past, all people i told to install FAF (WITHOUT instructing them how to do it) failed at one hurdle:
after installing FAF, creating (and confirming) an account, restarting it and clicking on one server a window appears: "please link FAF to your supreme commander forged alliance installation". you have to choose the installation folder of supcom:fa.
all my friends chose the forgedalliance.exe instead and could not use FAF.
in fact, i chose the forgedalliance.exe myself for one year until i found out by chance in the forum how to do it.

i suggested a change (nothing big, just change the description to make it more obvious and include an example how to do it an how to NOT do it). zep refused to do it.
i tried to do it myself, but the FAF lobby code contains so many different files and there is no universal search function. i also never worked with git and the whole experience was really confusing.

what do you think about it?

On the way:
https://github.com/FAForever/lobby/issu ... e-48627241

PS.: You can search on github
https://github.com/FAForever/lobby/sear ... =%E2%9C%93

EDIT:
It is already possible
Options -> Settings -> Game Path

Statistics: Posted by Dragonfire — 13 Nov 2014, 13:51

Re: New Lobby Awaiting Approval

2014-11-13T13:46:17+02:00

eXcalibur wrote:
i have a suggestion:

in the past, all people i told to install FAF (WITHOUT instructing them how to do it) failed at one hurdle:
after installing FAF, creating (and confirming) an account, restarting it and clicking on one server a window appears: "please link FAF to your supreme commander forged alliance installation". you have to choose the installation folder of supcom:fa.
all my friends chose the forgedalliance.exe instead and could not use FAF.
in fact, i chose the forgedalliance.exe myself for one year until i found out by chance in the forum how to do it.

i suggested a change (nothing big, just change the description to make it more obvious and include an example how to do it an how to NOT do it). zep refused to do it.
i tried to do it myself, but the FAF lobby code contains so many different files and there is no universal search function. i also never worked with git and the whole experience was really confusing.

what do you think about it?

This is unrelated to the ingame lobby, but indeed a good idea to make simple.

I'll make an issue for this on the lobby repo

EDIT: Up here: https://github.com/FAForever/lobby/issues/126

Statistics: Posted by Sheeo — 13 Nov 2014, 13:46

Re: New Lobby Awaiting Approval

2014-11-13T13:44:42+02:00

i have a suggestion:

in the past, all people i told to install FAF (WITHOUT instructing them how to do it) failed at one hurdle:
after installing FAF, creating (and confirming) an account, restarting it and clicking on one server a window appears: "please link FAF to your supreme commander forged alliance installation". you have to choose the installation folder of supcom:fa.
all my friends chose the forgedalliance.exe instead and could not use FAF.
in fact, i chose the forgedalliance.exe myself for one year until i found out by chance in the forum how to do it.

i suggested a change (nothing big, just change the description to make it more obvious and include an example how to do it an how to NOT do it). zep refused to do it.
i tried to do it myself, but the FAF lobby code contains so many different files and there is no universal search function. i also never worked with git and the whole experience was really confusing.

what do you think about it?

Statistics: Posted by eXcalibur — 13 Nov 2014, 13:44