Forged Alliance Forever

Re: Navy factory

2019-04-07T21:15:36+02:00

Is it possible to allow rotation of navy factories as well?

Some spots like setons island have a significant disadvantage with the default rotation of the factory

Statistics: Posted by noobymcnoobcake — 07 Apr 2019, 21:15

Re: Navy factory

2019-04-03T13:40:55+02:00

Did some more observations and testing on a few maps.

I retested it again in replay Replay UID : 9486337

The left side factory has a smooth roll off, the right side looks buggy. I thought it could be the terrain affecting the positioning of the factory and thereby the roll off. I have no other explanation why the one HQ rolls off smoothly and the other doesnt.

In Replay UID : 9486376

The same as in the previous replay. I also did some random spawns of factories in the ocean. Some of them had nice roll offs, others were a mess. It seemed to be random results, nothing obvious to point at that may be the cause.

In Replay UID : 9486410

Some factories had clean roll offs going north, others going south, none of them had both a clean north&south roll off.

My conclusion is that it is unlikely related to the terrain. All factories spawn the roll off way point in the same position theoretically. Maybe the units spawn off by a tiny margin before going into the roll off move order. What is clear is that the next unit doesnt start construction until the created way point is reached or abandoned (due to too much time spent spinning in circles) by the unit rolling off.

Statistics: Posted by Evildrew — 03 Apr 2019, 13:40

Re: Navy factory

2019-04-02T21:23:41+02:00

Happy Birthday Uveso!!!

Statistics: Posted by vongratz — 02 Apr 2019, 21:23

Re: Navy factory

2019-04-02T15:26:06+02:00

Evildrew wrote:
Sounds good, you have 24 hours -_-

I am sorry, but tomorrow is my birthday.
Don't expect me to do anything before Friday

Statistics: Posted by Uveso — 02 Apr 2019, 15:26

Re: Navy factory

2019-04-02T14:27:21+02:00

Just a hunch, I noticed that UEF and Cybran battleships have their central bone off centre while sera and aoen look to be exactly in the middle, my rolloff modifications showed to work for all T3 going out of the naval factory southwards, but uef and cybran needed more time to get to the rolloff point when going north. It might be possible that the Unit spin rotates the ships around their central axis being the parent bone and that makes the positioning be a little off between going out south/north.

I think we can rework the lod0 files to ensure that boats have the parent bone (f.ex. UES0302) in the middle as I believe it shouldnt affect anything ingame. It is visibile on the screenshot below how the spawning location on the UEF battleship is off. I am not sure if the parent bone is maybe a little more on the left or right of the absolute centre but that could also be affecting the roll off. Would need to check in blender.

It could also be the attachpoint on the factory that is off.

Statistics: Posted by Evildrew — 02 Apr 2019, 14:27

Re: Navy factory

2019-04-02T14:18:00+02:00

That wasn't my point. What I said happens even without any engies assisting the factory. I also tested it with all engies behind the factory, none were in the way of the unit being built and messing with pathing. Adding engies hurts even when they are in the right place because the unit somtimes glitches through the factory and then gets blocked by the engies anyway.

Statistics: Posted by ____ — 02 Apr 2019, 14:18

Re: Navy factory

2019-04-02T14:00:06+02:00

QuestionMarkNoob wrote:
I have noticed that with smaller ships like frigates the unit will firstly turn its head into the naval factory and then turn again in order to move out. This whole process sometimes takes up to 5 seconds and seems to be related to this move order.

For some factions this sometimes isn’t the case, while it is particularly bad for Cybran frigates for some reason. If you try it in a sandbox it is its clearly visible and reproducible most of the time.
When I tested it with UEF factories however the issue wasn’t really present, or at least not to the same extent as with Cybran. Also, it might be related to where the factory is facing.

Actually, now that I am testing it more thoroughly, it seems like battleships are also affected pretty severely sometimes. They don’t smash their head into the naval factory, but they sometimes just randomly make 360 degree turns instead of rolling out. It only happens sometimes, and it also depends on how many engies are assisting the fac. Overall it seems to happen randomly.

We can consider not microing engies into the right position when assisting the factory as lack of skill -_-

But on a serious note, the issue mainly shows with T3 navy units that roll off southwards, interestingly T3 Aoen and Seraphim boats have much less problems getting out of the entangling factories as uef and cybran do when rolling out northwards...

Statistics: Posted by Evildrew — 02 Apr 2019, 14:00

Re: Navy factory

2019-04-02T12:51:19+02:00

I have noticed that with smaller ships like frigates the unit will firstly turn its head into the naval factory and then turn again in order to move out. This whole process sometimes takes up to 5 seconds and seems to be related to this move order.

For some factions this sometimes isn’t the case, while it is particularly bad for Cybran frigates for some reason. If you try it in a sandbox it is its clearly visible and reproducible most of the time.
When I tested it with UEF factories however the issue wasn’t really present, or at least not to the same extent as with Cybran. Also, it might be related to where the factory is facing.

Actually, now that I am testing it more thoroughly, it seems like battleships are also affected pretty severely sometimes. They don’t smash their head into the naval factory, but they sometimes just randomly make 360 degree turns instead of rolling out. It only happens sometimes, and it also depends on how many engies are assisting the fac. Overall it seems to happen randomly.

Statistics: Posted by ____ — 02 Apr 2019, 12:51

Re: Navy factory

2019-04-02T12:45:49+02:00

Uveso wrote:
Just an Idea:

We could change this function to get the blueprint skirt size from the unit in case its a ship or naval factory:
https://github.com/FAForever/fa/blob/3b73337e27608d094fba5ed20c772833c9e21d1f/lua/defaultunits.lua#L757

Then we overload the function RollOffUnit with (ShipSize)
https://github.com/FAForever/fa/blob/3b73337e27608d094fba5ed20c772833c9e21d1f/lua/defaultunits.lua#L813

After this we can call the CalculateRollOffPoint also with (ShipSize)
https://github.com/FAForever/fa/blob/3b73337e27608d094fba5ed20c772833c9e21d1f/lua/defaultunits.lua#L818

If we do so, we can calculate a propper Unit RollOffPoint dependent on the ship size, no matter what techlevel it has.

Sounds good, you have 24 hours -_-

Actually I dont know what skirt size does, I experimented with it in the factory blueprint but didnt notice any change. I hope your idea works, I am doubtful we can make the way point be different for different tech level units to use my T3 boat solution. But never says never, always good to have a plan B.

Statistics: Posted by Evildrew — 02 Apr 2019, 12:45

Re: Navy factory

2019-04-02T12:18:51+02:00

Just an Idea:

We could change this function to get the blueprint skirt size from the unit in case its a ship or naval factory:
https://github.com/FAForever/fa/blob/3b73337e27608d094fba5ed20c772833c9e21d1f/lua/defaultunits.lua#L757

Then we overload the function RollOffUnit with (ShipSize)
https://github.com/FAForever/fa/blob/3b73337e27608d094fba5ed20c772833c9e21d1f/lua/defaultunits.lua#L813

After this we can call the CalculateRollOffPoint also with (ShipSize)
https://github.com/FAForever/fa/blob/3b73337e27608d094fba5ed20c772833c9e21d1f/lua/defaultunits.lua#L818

If we do so, we can calculate a propper Unit RollOffPoint dependent on the ship size, no matter what techlevel it has.

Statistics: Posted by Uveso — 02 Apr 2019, 12:18

Re: Navy factory

2019-04-02T11:40:51+02:00

I managed to improve the roll of sequence for T3 ships from T3 factory with the settings below. Unfortunately it slightly increases the T2 and T1 ships rolling out of a T3 factory to reach the way point and start the next unit since T1&T2 dont get stuck and spin in circles before giving up the rolloff waypoint like T3 do in the current settings...

UEF T3:
RollOffPoints = {
{
UnitSpin = 180,
X = -8,
Y = 0,
Z = -6,
},
{
UnitSpin = 0,
X = -8,
Y = 0,
Z = 6,

Cybran T3:
RollOffPoints = {
{
UnitSpin = 180,
X = -8,
Y = 0,
Z = -4,
},
{
UnitSpin = 0,
X = -8,
Y = 0,
Z = 4,

Seraphim T3:
RollOffPoints = {
{
UnitSpin = 180,
X = 8,
Y = 0,
Z = -4,
},
{
UnitSpin = 0,
X = 8,
Y = 0,
Z = 4,

Aoen T3:
RollOffPoints = {
{
UnitSpin = 180,
X = -8,
Y = 0,
Z = -5,
},
{
UnitSpin = 0,
X = -8,
Y = 0,
Z = 5,

Statistics: Posted by Evildrew — 02 Apr 2019, 11:40

Re: Navy factory

2019-04-02T11:14:33+02:00

Cool, I can work with that to make an improved rolloff. Is there a way to change the distance between the factory and the boat that is built while it is being constructed before rolling off?

Statistics: Posted by Evildrew — 02 Apr 2019, 11:14

Re: Navy factory

2019-04-02T11:08:34+02:00

Well it looks like some of these could be fixed generally. The units from the naval factory wont ever get that close as it is right now. It would need proper testing if the changes help tho...

Statistics: Posted by speed2 — 02 Apr 2019, 11:08

Re: Navy factory

2019-04-02T09:28:19+02:00

Sure, you can change the unit RollOffPoint inside the factory blueprint:
https://github.com/FAForever/fa/blob/3b73337e27608d094fba5ed20c772833c9e21d1f/units/URB0103/URB0103_unit.bp#L204

If you change "x = -2" to "x = -3" in both arrays then you will get this:

RollOffPointFixed.png

Statistics: Posted by Uveso — 02 Apr 2019, 09:28

Re: Navy factory

2019-04-02T07:55:51+02:00

Can it be moved to the side a bit?

Statistics: Posted by Evildrew — 02 Apr 2019, 07:55