Forged Alliance Forever

Re: [bug] Phantom X - phantom is revealed

2012-06-08T13:45:22+02:00

Thanks

Statistics: Posted by noobymcnoobcake — 08 Jun 2012, 13:45

Re: [bug] Phantom X - phantom is revealed

2012-06-08T13:24:54+02:00

noobymcnoobcake wrote:
Also phantom reveal time should not be cumulative. It should also be the total time showed. For instance if it said 15 min then it should show 15 mins into the game not 15+8. For second and third phantoms it should be exactly the same, not adding on the first phantom time. there should be longer time options added because of this.

Actually, it's really programmers choice. The mod was originally designed to be declare time (8 minutes) + reveal time. The lobby descriptions for the phantom 2 reveal time and phantom 3 reveal time clearly say they are cumlative. Rearranging the UI means rewriting and tweaking several code sections (it's not just a simple math change). As long as one can do some quick math, one can figure out the appropriate settings to use.

However, I see two points in what you're requesting that may need to be fixed.
1. Description for option 1 needs to say that it's the time after declare (i.e. 8 min + reveal time)
2. One can't reveal multiple phantoms at the same time.

I'll add those to my todo list to look at.

Statistics: Posted by Duck_42 — 08 Jun 2012, 13:24

Re: [bug] Phantom X - phantom is revealed

2012-06-08T12:31:36+02:00

Also phantom reveal time should not be cumulative. It should also be the total time showed. For instance if it said 15 min then it should show 15 mins into the game not 15+8. For second and third phantoms it should be exactly the same, not adding on the first phantom time. there should be longer time options added because of this.

Statistics: Posted by noobymcnoobcake — 08 Jun 2012, 12:31

Re: [bug] Phantom X - phantom is revealed

2012-06-04T16:33:09+02:00

Thats why I posted in in general bugs topic, but Zep said I should post it here.

Statistics: Posted by noobymcnoobcake — 04 Jun 2012, 16:33

Re: [bug] Phantom X - phantom is revealed

2012-06-03T19:44:06+02:00

noobymcnoobcake wrote:
Was playing phantom game. Decided to build an Atlantis after base was smashed by yotha. The UEF box was there but the actual Atlantis was not. Ended up abandoning it and building another. Resources were used up but I never got the unit.

http://www.2shared.com/file/CgndPQcQ/14 ... bcake.html

Hmmm. It does show up weird in the replay. I don't know of anything in the Phantom-X mod that would directly affect units (other than mass and energy storage) though. As I mentioned, there's a script error in the first fix that I posted, but I would think that any problems from that would be limited to the scope of the Phantom-X script.

Statistics: Posted by Duck_42 — 03 Jun 2012, 19:44

Re: [bug] Phantom X - phantom is revealed

2012-06-03T19:23:15+02:00

Was playing phantom game. Decided to build an Atlantis after base was smashed by yotha. The UEF box was there but the actual Atlantis was not. Ended up abandoning it and building another. Resources were used up but I never got the unit.

http://www.2shared.com/file/CgndPQcQ/14 ... bcake.html

Statistics: Posted by noobymcnoobcake — 03 Jun 2012, 19:23

Re: [bug] Phantom X - phantom is revealed

2012-06-03T19:13:01+02:00

I think Funk is right about the storage. Just need Zep to remove the bp files .

So, here's the next code fix:
-Fixed the announcements bug
-Added phantom numbering to UI
-Fixed countdown timer problem

Phantom-X Fix 2.zip

For future reference, how to go about testing the mod code?

I read somewhere that it has to be in an SCD file because it changes the lobby options. I've tried it several other ways, and none of them will show the reveal time options in the lobby, so is there anything special about creating an scd file (or can I just take the phantomx.phx, edit it, rename it to .scd, and drop it in the gamedata somewhere)? Not having the lobby options makes it a little hard to test the thing.

Statistics: Posted by Duck_42 — 03 Jun 2012, 19:13

Re: [bug] Phantom X - phantom is revealed

2012-06-03T18:36:35+02:00

Duck_42 wrote:
Changing the storage should just be a matter of adjusting the blueprint files. I'll see about fixing that.

Removing the bps will revert them to default FAF files. I think the script file controls he appears of full vs empty.

Statistics: Posted by FunkOff — 03 Jun 2012, 18:36

Re: [bug] Phantom X - phantom is revealed

2012-06-03T18:34:08+02:00

Changing the storage should just be a matter of adjusting the blueprint files. I'll see about fixing that.

I also misunderstood the Sync.pAlert syntax when I was fixing the LUA code, so I broke part of the announcements in my fix.

So, for the next fix, I've got:
-Fix announcement bug
-Correct energy and mass storage values
-Add phantom numbering to assignment display (so if you're phantom, you'll know where you are in the reveal order).
-Fix reveal countdown timer so that it doesn't keep counting down after all revealable phantoms have been shown.
(this only happens if Phantom 1 or 2 are set to never and phantom 2 or 3 are set to some number)

Statistics: Posted by Duck_42 — 03 Jun 2012, 18:34

Re: [bug] Phantom X - phantom is revealed

2012-06-03T18:04:30+02:00

Another issue - Storages have 3599 values. E storage only holds 2k. I believe they were changed so they dont go up and down. This is because you could tell who the phantoms were by watching then as phantoms get resource bonuses.

Statistics: Posted by noobymcnoobcake — 03 Jun 2012, 18:04

Re: [bug] Phantom X - phantom is revealed

2012-06-03T17:17:40+02:00

Thank you very much Duck_42, really appreciate the initiative.

Statistics: Posted by uberge3k — 03 Jun 2012, 17:17

Re: [bug] Phantom X - phantom is revealed

2012-06-03T17:11:13+02:00

Thanks Zep ^^

Statistics: Posted by noobymcnoobcake — 03 Jun 2012, 17:11

Re: [bug] Phantom X - phantom is revealed

2012-06-03T16:47:22+02:00

That's the spirit, if you want something done, do it !

Thank you, I'm updating the online version.

Statistics: Posted by Ze_PilOt — 03 Jun 2012, 16:47

Re: [bug] Phantom X - phantom is revealed

2012-06-03T10:52:05+02:00

Doesn't really matter I think, we only have to let this be applied in a central FAF update and all accounts will follow as soon as they log in.

Statistics: Posted by Plasma_Wolf — 03 Jun 2012, 10:52

Re: [bug] Phantom X - phantom is revealed

2012-06-03T10:30:29+02:00

Yes i noticed this too. Now if only we can get them to put that in update.

Does only the host need this fix? Or everyone in the game?

Statistics: Posted by noobymcnoobcake — 03 Jun 2012, 10:30