Coming in patch 3635

Post here if you want to help developing something for FAF.

Re: Coming in patch 3635

Postby Shadows » 13 Oct 2014, 20:43

Sheeo wrote:The change that was previously implemented (It's not on github), duplicated the icon along with its name. So we would have this issue with people using old mods.

The change is only to allow ASI to do this, so if you have an idea of what to do please let me know :)

In order to keep compatibility with older icon mods, the implementation of my idea should look like this:

Code: Select all
UnitBlueprint {
   Merge = true,
   BlueprintId = "ueb1106",
        StrategicIconName = get_name_if_file_exist('icon_structure1_mass_storage', StrategicIconName)
}

function get_name_if_file_exist(new_file_name, default_file_name)
  local file_found=io.open(new_file_name, "r")     
  if file_found==nil then
        io.close(file_found)
        return default_file_name
  else
        io.close(file_found)
        return new_file_name
  end
end

The function sets the new icon's file name if the icon file exist, otherwise it leaves it at default.
(LUA is not my programing language).
User avatar
Shadows
Avatar-of-War
 
Posts: 178
Joined: 09 Jan 2013, 00:02
Has liked: 1 time
Been liked: 35 times
FAF User Name: Shadows

Re: Coming in patch 3635

Postby Ze_PilOt » 14 Oct 2014, 07:54

Shadows wrote:
Sheeo wrote:
Sir Prize wrote:Thank you devs!

I PMed Sheeo about a month ago I think asking if T1 Mass Extractors could have their strategic icon separated in the blueprints from T1 Mass Storage. It sounded like it was easy to do and would get up - any update on this?

Thanks again for your work guys.


Of course, I'll make sure to push this change later today :)

EDIT: It's done here: https://bitbucket.org/thepilot/forged-alliance-forever-lua/pull-request/116/new-icon-name-for-mass-storage

The link is broken.


The FAF repository is now in visionik hands:

https://bitbucket.org/visionik/forged-a ... ss-storage
Nossa wrote:I've never played GPG or even heard of FA until FAF started blowing up.
User avatar
Ze_PilOt
Supreme Commander
 
Posts: 8985
Joined: 24 Aug 2011, 18:41
Location: fafland
Has liked: 18 times
Been liked: 376 times
FAF User Name: Ze_PilOt

Re: Coming in patch 3635

Postby Krapougnak » 22 Oct 2014, 09:10

What happened to patch 3635 ? Next patch seems to be numbered 3636.
User avatar
Krapougnak
Contributor
 
Posts: 340
Joined: 12 Jul 2012, 11:03
Has liked: 193 times
Been liked: 24 times
FAF User Name: Krapougnak

Re: Coming in patch 3635

Postby pip » 22 Oct 2014, 10:40

Patch 3635 was released, then withdrawn shortly after, and now 3636 is a bit different so it has new number.
pip
Supreme Commander
 
Posts: 1826
Joined: 04 Oct 2011, 15:33
Has liked: 191 times
Been liked: 86 times
FAF User Name: pip

Re: Coming in patch 3635

Postby The Mak » 22 Oct 2014, 15:41

Just so we are clear, which repository are we using now:

Visionick's Bitbucket
or
GitHub


I see Github has some recent changes, but Visionick's Bitbucket is listed in the sticky.
User avatar
The Mak
Contributor
 
Posts: 342
Joined: 03 Mar 2012, 21:09
Location: New York, NY, USA
Has liked: 5 times
Been liked: 39 times
FAF User Name: The_Mak

Re: Coming in patch 3635

Postby IceDreamer » 22 Oct 2014, 20:32

Github is where all primary development is being driven.
IceDreamer
Supreme Commander
 
Posts: 2607
Joined: 27 Dec 2011, 07:01
Has liked: 138 times
Been liked: 488 times

Re: Coming in patch 3635

Postby Ze_PilOt » 22 Oct 2014, 20:36

The official and controlled repository is the bitbucket one.

The git is used for development, but as no team is made yet, the changes commited there are not approved by anyone but the owner of the repository (who is not the owner of the server).
Nossa wrote:I've never played GPG or even heard of FA until FAF started blowing up.
User avatar
Ze_PilOt
Supreme Commander
 
Posts: 8985
Joined: 24 Aug 2011, 18:41
Location: fafland
Has liked: 18 times
Been liked: 376 times
FAF User Name: Ze_PilOt

Re: Coming in patch 3635

Postby Nombringer » 22 Oct 2014, 20:45

Not sure if this is inside the scope of this patch, but I think it would be a great improvement if mass extractors had a higher target priority than mass storage.

I'm not sure if this is really "balance" change, just a convenience one, as whenever you do a runby you have to manually target the mex's and a bunch of the damage gets wasted.



Oh, and aeon t1 bombers will still target amphibious units, such as the ACU or wagers, while they are underwater.
BC_Blackheart: i just copy his shit and do it 5% better leads to easy win usually xD

Need help? Are you a new player? Feel free to message me any time in the lobby :) Lessons may cost a portoin of your soul.... (Noms are included but not guaranteed)
Nombringer
Supreme Commander
 
Posts: 1036
Joined: 16 Nov 2012, 06:31
Has liked: 210 times
Been liked: 65 times
FAF User Name: Nombringer

Re: Coming in patch 3635

Postby IceDreamer » 23 Oct 2014, 01:30

Ze_PilOt wrote:The git is used for development, but as no team is made yet, the changes commited there are not approved by anyone but the owner of the repository (who is not the owner of the server).


The only named owner of the Github repository is visionik, who is (I believe) the owner of the server...
IceDreamer
Supreme Commander
 
Posts: 2607
Joined: 27 Dec 2011, 07:01
Has liked: 138 times
Been liked: 488 times

Previous

Return to Contributors

Who is online

Users browsing this forum: No registered users and 1 guest