Copyright code audit

Post here if you want to help developing something for FAF.

Copyright code audit

Postby Benzi_Junior » 03 Apr 2019, 01:32

In this forum post Mountain talks about a need to perform a code audit to make sure that no copyrighted code is being distributed with FAF.
What are the conditions, I mean how does one identify the copyrighted portions of code.

I would like to know what needs to be done in order to alleviate the steam account linking constraint so I could help speed things along.
Benzi_Junior
 
Posts: 1
Joined: 03 Apr 2019, 01:04
Has liked: 0 time
Been liked: 0 time
FAF User Name: BJ

Re: Copyright code audit

Postby Geosearchef » 03 Apr 2019, 10:30

The patcher needs to be finished. It needs to be able to detect the locally installed FA version and ship the correct patch for that.

The patches won't contain any copyrighted content, only the changes between the normal version and the FAF version.


https://github.com/Brutus5000/deltaforge
Developer, Server Admin, ICE, currently working on Team Matchmaking, FAF Client
User avatar
Geosearchef
Priest
 
Posts: 359
Joined: 18 Oct 2013, 14:08
Location: Germany
Has liked: 5 times
Been liked: 114 times
FAF User Name: Geosearchef

Re: Copyright code audit

Postby Little Miss Murder » 03 Apr 2019, 13:15

I assume this does not affect Steam versions?
User avatar
Little Miss Murder
Avatar-of-War
 
Posts: 138
Joined: 30 Mar 2019, 12:20
Has liked: 80 times
Been liked: 20 times
FAF User Name: Little Miss Murder

Re: Copyright code audit

Postby Geosearchef » 03 Apr 2019, 14:39

Euhm, why shouldn't it affect the steam version? That's the issue. People may have different versions and therefore the patches need to be different.
Developer, Server Admin, ICE, currently working on Team Matchmaking, FAF Client
User avatar
Geosearchef
Priest
 
Posts: 359
Joined: 18 Oct 2013, 14:08
Location: Germany
Has liked: 5 times
Been liked: 114 times
FAF User Name: Geosearchef

Re: Copyright code audit

Postby Brutus5000 » 05 Apr 2019, 01:11

The game version distributed by FAForever depends on code originally written by GPG and therefore copyrighted.

Our developer community does not have the knowledge and power to rewrite the whole game code under a free license. The original code was modified in multiple points to enable hooking in of custom code, so that we do not need to modify that many original files. And we only distribute those files that we have changed. But that doesn't matter. Strictly speaking, a single file containing a single line of copyrighted code would be enough to cause legal issues.

As such the idea is not to stop modifying the files, but to alter the way we bring the modified file onto the user's computer.
So instead of downloading the modified file from the FAF servers, in the future, you will only download the binary difference between the file that is on your computer and the file we want you to have on your computer. The assembling of the desired file will happen locally on the user's computer.

The additional complexity here is that there is more than one version of Forged Alliance installed on people's computers. There are multiple retail versions (the original, a gold edition, steam edition, etc.) which contains different versions. So before we can start to distribute patches we also need to make sure that all users work on the same baseline code.

This is basically what I am trying to achieve with my project deltaforge. I have updated the readme to give a little more insight on how it's going to work.
The 9th Doctor wrote:You think it'll last forever, the people and cars and concrete. But it won't. One day it's all gone, even the sky.
Brutus5000
Site Admin
 
Posts: 270
Joined: 05 Aug 2016, 23:32
Has liked: 27 times
Been liked: 239 times
FAF User Name: brutus5000

Re: Copyright code audit

Postby Cuddles » 05 Apr 2019, 09:18

Yea paying $2 on steam for a game you play allot is really a pain.
Turinturambar defended very valiantly
User avatar
Cuddles
Contributor
 
Posts: 684
Joined: 29 Mar 2013, 14:19
Has liked: 131 times
Been liked: 118 times
FAF User Name: Scoot

Re: Copyright code audit

Postby Geosearchef » 05 Apr 2019, 10:11

@Cuddles

Technically steam linking doesn't change anything about the leagal situation.
Developer, Server Admin, ICE, currently working on Team Matchmaking, FAF Client
User avatar
Geosearchef
Priest
 
Posts: 359
Joined: 18 Oct 2013, 14:08
Location: Germany
Has liked: 5 times
Been liked: 114 times
FAF User Name: Geosearchef

Re: Copyright code audit

Postby ZLO_RD » 05 Apr 2019, 11:02

Cuddles wrote:Yea paying $2 on steam for a game you play allot is really a pain.

it adds addictional step to registration, and people often have trouble with steam linking.
afaik it is only about 2$ on sale, often it is about 5-7$, and there might be new people who are forced to pay for game that they nothing about.
many players are kids and don't have much money.
http://www.youtube.com/user/dimatularus
http://www.twitch.tv/zlo_rd
TA4Life: "At the very least we are not slaves to the UI"
User avatar
ZLO_RD
Supreme Commander
 
Posts: 2178
Joined: 27 Oct 2011, 13:57
Location: Russia, Tula
Has liked: 290 times
Been liked: 368 times
FAF User Name: ZLO

Re: Copyright code audit

Postby Brutus5000 » 05 Apr 2019, 15:07

ZLO_RD wrote:many players are kids and don't have much money.


But they bought the game 10 years ago in real stores *and* are unable to redeem it on Steam?
In general, I agree that the steam linking is annoying (also from the support side). But that argumentation is just nonsense.
The 9th Doctor wrote:You think it'll last forever, the people and cars and concrete. But it won't. One day it's all gone, even the sky.
Brutus5000
Site Admin
 
Posts: 270
Joined: 05 Aug 2016, 23:32
Has liked: 27 times
Been liked: 239 times
FAF User Name: brutus5000

Re: Copyright code audit

Postby Cuddles » 05 Apr 2019, 21:54

I don't think it's anything to do with some misguided social activism against steam or money related problems, more likely ban circumvention or smurffing. Both points to mental disease. Maybe that's unfair, who knows. Honest explanations is not forthcoming and administrators is bound by non disclosure.

Sorry for hijacking OP. feel free to have my posts moderated.
Turinturambar defended very valiantly
User avatar
Cuddles
Contributor
 
Posts: 684
Joined: 29 Mar 2013, 14:19
Has liked: 131 times
Been liked: 118 times
FAF User Name: Scoot


Return to Contributors

Who is online

Users browsing this forum: No registered users and 1 guest