Important Mods are not in the Vault

[armacham01]

The updated version of "Supreme Score Board" is not in the vault

Last week, "Common Mod Tools" wasn't in the vault

What is going on and who is fixing it?

[vongratz]

Nor kindness.This people that mantain the FAF alive dont receive any dime, and deserve a lot of friendship and respect.

[Morax]

Hey, arma,

First and foremost, can you please tell me the precise name of the modification?

You will notice this and other modifications may be missing/hidden/etc over the next few months as I embark on work to clean out broken/rule-breaking [See FAF Modification Vault Rules] content in the vault. As the vault has been in existence for several years without any regulation, I do think there will be some friction as this process begins and becomes normal.

First, to answer your question, I most likely hid the modification in error: Hussar had several versions within, and when I look in the moderator client I found that various versions were uploaded under "hussar," "unknown author," "husar_pl," etc.

Spoiler: show

This leads to a lot of confusion as the FAF modification vault shows the uploader as a user-editable text string. The map vault uses the FAF username, which updates as he/she changes their name. Since the modification vault does not do this, there can be several misinterpretations made; for instance, I found a mod called "Wyvern Battle Pack" which used stolen assets from a community. To make matters worse, the uploader put a FAF user "chp2001" in the author field when really, it was FAF user:

Spoiler: show

So without writing too much more, here are all the pieces to the puzzle from my point of view:

https://imgur.com/a/p578KoT

For those who encounter a similar issue and believe a modification should not have been removed, please go to the M&M Discord, head to the "Administration" section of the channels on the left and post up in one of these:



The moderator client does what it needs, but is imperfect and can lead to easy mistakes. For instance, you can only hide one version of a map or modification at a time, and with many modifications having 200+ versions it's quite easy to forget to not select the latest, or correct version. I have been waiting half a year for this to be addressed:

https://github.com/FAForever/faf-modera ... issues/106

This is not me trying to say the developers are bad because this has not been addressed, but more a reminder FAF is a free service, and we can only expect so much. If you want something more premium, then donate some MONEYS to them like it's a real job, and then you can make some expectations

Regardless, I am going to attempt to do what I think is best for the community:

1) Highlight the best modifications out there, demo them, just as keyser expressed in his thread for UI modifications (there are more then UI mods that need discussing!)
2) Remove stolen content
3) Address broken/malfunctioning/game-desync-causing modifications

I hope this answers you well and you understand what it happening in the background. Not everything with modifications will be under me, but if you ask it will certainly be me who helps you figure out what happened.

[armacham01]

Thank you, Morax. I really appreciate your responsiveness to my concerns. I know the mod vault is large and cleaning up incorrect versions of mods will be very helpful.

The mod is named "Supreme Score Board." (Not particularly helpful, but I don't see a more specific name)

Here is the contents of mod_info.lua from the mod itself. According to that file, the version I have is version 2. It doesn't say when version 2 came out, but it says version 1.4 was released in October 2017, so even v1.4 is more recent than what is currently in the mod vault.

Also, the forum thread (viewtopic.php?f=41&t=10887) indicates that the most recent version is Version 2. The download link in the forum thread appears to still be active, so you could get it from there in order to put it back into the vault.

Code: Select all

-- #########################################################
name         = "Supreme Score Board"
-- #########################################################
version      = 2
uid          = "HUSSAR-PL-a1e2-c4t4-scfa-ssbmod-v0020"
author       = "HUSSAR"
copyright    = "HUSSAR, free to re-use code as long as you credit me in your mod"
contributors = "Anihilnine, Crotalus, Speed2, MaCielPL, Nojoke, Petricpwnz, Nexus_of_Reality, Col_Walter_Kurtz, PsychoBoB"
description  = "Improves score board and replays by adding more columns, team stats, players sorting, filtering units by type and more. Now with support for new army colors. (HUSSAR)"
--icon         = "mod_icon.png"
icon         = "/mods/SupremeScoreBoard/mod_icon.png"
url          = "http://forums.faforever.com/viewtopic.php?f=41&t=10887"
selectable   = true
enabled      = true
ui_only      = true
exclusive    = false
requiresNames = { }
requires      = { }
-- this mod will conflict with all mods that modify score.lua file:
conflicts   = {
    "9B5F858A-163C-4AF1-B846-A884572E61A5", -- INTERGRATED lazyshare 
    "b0059a8c-d9ab-4c30-adcc-31c16580b59d", -- INTERGRATED lazyshare 
    "c31fafc0-8199-11dd-ad8b-0866200c9a68", -- INTERGRATED coloured allies in score
    "89BF1572-9EA8-11DC-1313-635F56D89591", --
    "f8d8c95a-71e7-4978-921e-8765beb328e8", --
    "HUSSAR-PL-a1e2-c4t4-scfa-ssbmod-v1100", -- old SSB
    "HUSSAR-PL-a1e2-c4t4-scfa-ssbmod-v1200", -- old SSB
    "HUSSAR-PL-a1e2-c4t4-scfa-ssbmod-v1230", -- old SSB
    "HUSSAR-PL-a1e2-c4t4-scfa-ssbmod-v1300", -- old SSB
    "HUSSAR-PL-a1e2-c4t4-scfa-ssbmod-v1400", -- old SSB
    "HUSSAR-PL-a1e2-c4t4-scfa-ssbmod-v1500", -- old SSB
    "HUSSAR-pl-a1e2-c4t4-scfa-SETmod-v0100",
    "HUSSAR-PL-a1e2-c4t4-scfa-SUImod-v0900", -- old SUI v0.9
    }
before = { }
after = {
    "zcbf6277-24e3-437a-b968-Common-v1",
    "0faf3333-1122-633s-ya-VX0000001000",   -- eco info - sharing among your team
    "b2cde810-15d0-4bfa-af66-ec2d6ecd561b", -- eco manager v3
    "ecbf6277-24e3-437a-b968-EcoManager-v4",
    "ecbf6277-24e3-437a-b968-EcoManager-v5",
    "ecbf6277-24e3-437a-b968-EcoManager-v6",
    "ecbf6277-24e3-437a-b968-EcoManager-v7",
    "ecbf6277-24e3-437a-b968-EcoManager-v8",
    "ecbf6277-24e3-437a-b968-EcoManager-v9",
}
--------------------------------------------------------------------------------------
--[[ TODO
add ping info about players (lua/modules/ui/game/connectivity.lua)
show acu kills and mvp kill ratio 
group players colors before selecting team color to avoid green team color if two green players are in two teams

add build power based on players engineers (requires fix in score data)
add images to notifications for built experimental units (requires fix in FAF score data)
add exp voice over from lua\ui\game\vo_computer.lua
add army compare (strength, DPS, mass value) between teams (in replay session)
add army overview with status of built TMLs. Nukes, HP for each major unit type (in game session)
add more notifications about built nukes/t3 arty/experimental (in replay session)
add stacked build menu (no tabs)
add supreme empire tree functionality with movable UI elements
-]]
--------------------------------------------------------------------------------------
-- MOD HISTORY
--------------------------------------------------------------------------------------
--[[ v1.4 - HUSSAR - October, 2017
--------------------------------------------------------------------------------------
-- fixed an issue with selecting text color for armies due to changes in FAF army colors
-- fixed an issue finding map quadrant for an army with incorrect army key defined in [map name]_save.lua
--]]
--------------------------------------------------------------------------------------
--[[ v1.3 - HUSSAR - July, 2016
--------------------------------------------------------------------------------------
- added info about who killed a player in Army notification window
- added info about who decided to CTRL+K in Army notification window
- added coloring of player names in Army notification window
- added mod configuration under Game -> Options -> Interface tab
- added interaction states for buttons in the sort line (first line of the score board)
- changed mouse interaction in top row, now left click will show values in columns
- changed mouse interaction in top row, now right click will sort values in columns
- fixed compatibility with other mods that modify score.lua (e.g. EcoManager) and SSB takes precedence over these mods
- fixed numbering of teams based on players' starting locations and map quadrants (per Gyle request)
- fixed messages with sent resources/units to allies (observer will see message target)
- fixed tooltip that shows unit restrictions and separated presets from custom restrictions
- fixed detection for unranked games (if restrictions count greater than zero)
- increased number of notifications for built experimental units (2 -> 5)
- increased precision for rounding large numbers (1.2m -> 1.23m)
- improved description of tooltips
--]]
--------------------------------------------------------------------------------------
--[[ v1.2 - HUSSAR - January, 2016
--------------------------------------------------------------------------------------
- (all sessions) added replay ID below map info line
- (all sessions) added calculation of game quality/balance if this value is not present in session options
- (game session) added buttons for sharing mass/energy/units with allied human players (faster than LazyShare)
- (game session) added buttons for sharing mass/energy/units with allied AI players
- (game session) added chat notifications for transferred amount of mass/energy to allied players
- (game session) added chat notifications for transferred number of units to allied players
- (game session) added separator lines between players' lines and teams' lines in game session
- (replay session) changed reclaim column to show reclaim values (works with latest FAF beta patch)
- (replay session) added auto-hiding multifunction panel because it is not used in replays at all
- (replay session) added auto-switching between score columns (e.g. units types air|land|naval)
- (replay session) clicking on a column toggle will disable auto-switching columns
- fixed coloring of player names when they are not in teams (e.g. Phantom games)
- fixed coloring of player names in replay session
- fixed information in tooltips
- fixed conditions for checking ranked games
- fixed teams statistics by including score data for dead players 
- fixed team status that shows how many players are still alive
- fixed detection of dead players in sandbox games
- fixed placement of icons in the sort line
- fixed alignment of top line with its background
- fixed very long map names by truncating them to 30 chars
- changed background of the score board to darker color (better visibility of player names)
- changed units column to show air/land/navy/all instead of cumulative values, e.g. air + navy
- changed ranking column to show exact values in ladder games and rounded values in regular games
- changed coloring of player names and now they will match color of team
- changed column with player names to include clan tags (if they exist)
--]]
--------------------------------------------------------------------------------------
--[[ v1.1 - HUSSAR - October 5, 2015
--------------------------------------------------------------------------------------
- fixed info about active mods in replay session
- fixed status of game raking
- fixed tooltip about game quality/balance
- added coloring of player names based on team color
- thanks to testers: Petricpwnz, Anihilnine
--]]
--------------------------------------------------------------------------------------
--[[ v1.0 - HUSSAR - September 25, 2015
--------------------------------------------------------------------------------------
- added team lines that sums up statistics for allied players
- added column with filters to show count of air/land/navy/base units 
- added column for total mass of collected/killed/lost
- added column for players rating to prevent clipping by score values
- added toggle to show and sort players by their army rating
- added toggle to show and sort players by total mass collected
- added toggle to show and sort players by total mass reclaimed*
- added toggle to show and sort players by total energy reclaimed*
- added toggle to show and sort players by total energy collected
- added toggle to show and sort players by their clan tags
- added toggle to show and sort players by Kills-to-Loses Ratio
- added toggle to show and sort players by Kills-to-Built Ratio
- added toggle to sort players by current mass income
- added toggle to sort players by current energy income
- added toggle to sort players by current score value
- added toggle to sort players by their army name
- added toggle to sort players by their clan tag
- added toggle to sort players by their team id
- added sorting by two columns when value in the first sorting are equal, e.g. sorting by team ID and then by mass income
- added team status showing alive/maximum players
- added rendering players names with red/green when in players view to show allies/enemies
- added calculation of AI rating based on AI type and AI cheat modifiers
- added field showing game quality based on network connection between players
- added tooltips for all new UI elements in the score panel
- added info about map size
- added icons with improved quality for mass, energy, units
- added icons with info about game restrictions
- added icons with info about active mods
- added icons with info about unit sharing
- added icons with info about victory conditions
- added icons with info about AI multipliers
- added notifications about 1st experimental unit built by a player
- changed game time/speed fields into two fields   
- changed unit counter to show unit count of all armies (in observer view) or just player's units (in player view)
- fixed missing tooltip for game speed slider
- fixed performance in updating score panel by limiting number of for loops (n*n-times to n-times)
- fixed issues with performing operations on uninitialized values of score data
- fixed redundant function calls to GetArmiesTable().armiesTable
- fixed redundant function calls to GetFocusArmy()
- fixed redundant function calls to SessionIsReplay()
- fixed redundant function calls to SessionGetScenarioInfo()
- fixed redundant imports of some LUA scripts (e.g. announcement.lua)
* pending FAF patch that will actually add reclaim values to score data and thus enable them to show in score panel
--]]
--------------------------------------------------------------------------------------
--[[ TEST NOTES:
-- maps big:    Seton's Clutch, The Dark Heart, Seraphim Glaciers, Twin Rivers
-- maps small:  Balvery Mountains Diversity
-- players:     Lainelas, Blackheart, Blackdeath, Foley, BRNKoINSANITY
-- ai           Neptune, EntropicVoid on The Dark Heart
-- max teams    Fractal Cancer, Seraphim Glaciers, White Fire
-- clans        SGI Nequilich e VoR

FAF bugs:
limit logging: "Particle cap exceeded, discarding excess."

logs line =  line# in this file + # of lines in original score.lua (615)
--]] 
--------------------------------------------------------------------------------------


[keyser]

just posting that here :


The 2 versions that haven't been hidden, and are available on the vault
edit : hint, look at hussar comments

[Morax]

Okay, just FYI this has been fixed! Version 2.0 of the modification is now in the vault again.

[Rowey]

Morax you could make it a IssuseHunt Request were people can donate money to issuses and could promt someone to look in to it https://issuehunt.io/r/FAForever/downlords-faf-client?

[Morax]

I don't require payment and don't think we should prioritize matters in FaF based on money.

We should be working together for the simple enjoyment that we are still able to play this great game.