Invalid custom scores

[Ze_PilOt]

I've pushed a fix 30 min ago, was it before that ?

[thygrrr]

I've pushed a fix 30 min ago, was it before that ?

YES, 17:55 or so for the first game. Could have been exactly at that time for the first game (maybe check your server logs). But I started a 4th game and it was 0/-1 again.

[Ze_PilOt]

0/-1 seems correct if you don't wait for the victory popup.

I've look at the log, I see you don't wait for it (no victory message to the server

[thygrrr]

I did wait both times. I did quit with the suiciding commander first, clicking on score, and then leaving the score screen.

[Kryo]

still another unreported game (maybe one player left FAF before leaving the game?)

around 19 Feb 2012 17-33 it was 3on3 on cold valley

Kryo techflex bergi84 vs drg alephnull +1 more

[Ze_PilOt]

Last update was faulty, new one is correct.

Kryo : someone didn't disconnect properly

Seems that there is still one case where FAF cannot send that FA is closed...

[thygrrr]

I can make is to FAF keeps the server connection alive until FA is terminated if it can.

Would that be an option? Currently it just keeps the process alive until the player either finishes FA or tells FAF to kill it.

[Kryo]

what about:

If a player closes FAF, check if he is still ingame in FA, and if so, report it as a disconnect or lose

[thygrrr]

That's an interesting approach, but not necessary.
You cannot (!) close FAF without closing FA. all I need to ensure is that the "FA_CLOSED" message is sent before the server connection is severed.

I'll check where and when it disconnects in Client.cleanup() ... Probably a smidgen too early, that's all.

[Ze_PilOt]

Most of the problem rely in the game server failing to see the connection as closed.
I've a ping system for the lobby, but I can't implement that for FA.

But if FAF is closed, the gamesocket should be closed too (the disconnection function of FAF send a close socket on any game thread for the user). Seems that in one case it fails, I have to investigate server-side.